Skip to content

feat: add cube root validation in FFLONK verifier #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add cube root validation in FFLONK verifier #584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/fflonk_verify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ export default async function fflonkVerify(_vk_verifier, _publicSignals, _proof,

const vk = fromObjectVk(curve, _vk_verifier);

// TODO ??? Compute wr^3 and check if it matches with w

const proof = new Proof(curve, logger);
proof.fromObjectProof(_proof);

Expand All @@ -49,6 +47,13 @@ export default async function fflonkVerify(_vk_verifier, _publicSignals, _proof,

const Fr = curve.Fr;

// Validate that wr^3 = w (cube root relationship)
const wrCubed = Fr.mul(Fr.mul(vk.wr, vk.wr), vk.wr);
if (!Fr.eq(wrCubed, vk.w)) {
if (logger) logger.error("Invalid verification key: wr^3 does not equal w");
return false;
}

if (logger) {
logger.info("----------------------------");
logger.info(" FFLONK VERIFY SETTINGS");
Expand Down