[ test ] Use clean_names in tests by default

[spcfox]

Description

Often, when changing compilers, differences in machine names are detected in tests. I think it would be useful to apply clean_names to all tests by default.

Self-check

• This is my first time contributing, I've carefully read CONTRIBUTING.md
  and I've updated CONTRIBUTORS.md with my name.
• If this is a fix, user-facing change, a compiler change, or a new paper
  implementation, I have updated CHANGELOG_NEXT.md

[spcfox]

I think we should remove the location in the names of implementations. This will make the tests resistant to changes in Prelude.

[spcfox]

Perhaps we should only clean locators after (implementation | case block | with block) at?

[dunhamsteve]

If we wanted to be precise we could do after (implementation | case block | with block) at but also after ^LOG.

My only reservation with what you have is that we might loose tests for locations of errors (e.g. sometimes unification errors will name a and put a location after it), but we could choose to not use clean_names in tests where it is an issue.

[spcfox]

I think it shouldn't affect locations in errors now

[spcfox]

Windows hangs every time in this PR. Maybe clean_names is hanging there?

[dunhamsteve]

That could be, it looks like the while loop expects the replacement to leave something that doesn't match the original regex.

We need a termination checker for AWK. :)

[spcfox]

Windows hangs every time in this PR. Maybe clean_names is hanging there?

I've made many runs. It seems like it's just bad luck

UPD: Or not. It doesn't always hang, but it seems to happen more often than usual.

[spcfox]

Windows hangs every time in this PR. Maybe clean_names is hanging there?

I've made many runs. It seems like it's just bad luck

UPD: Or not. It doesn't always hang, but it seems to happen more often than usual.

The reason is the channels009 test. There were problems with it before. I suggest disabling it temporarily. PR #3617 is working on fixing it.

[gallais]

Happy to merge this whenever it's ready to go.