Add tests for GreedyPlayerView

.github/workflows/danger.yml

@@ -23,6 +23,6 @@ jobs:
     steps:
       - uses: actions/checkout@v2
       - name: Danger
-        uses: docker://ghcr.io/danger/danger-swift-with-swiftlint:3.12.3
+        uses: docker://ghcr.io/danger/danger-swift-with-swiftlint:3.15.0
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/swift-build.yml

@@ -32,4 +32,6 @@ jobs:
       with:
         xcode-version: '${{ matrix.ios.xcode }}'
     - name: Build and Test (iOS ${{ matrix.ios.version }})
-      run: xcodebuild build -scheme GreedyKit -destination 'platform=iOS Simulator,OS=${{ matrix.ios.version }},name=${{ matrix.ios.device }}' test | xcbeautify
+      run: |
+        set -o pipefail
+        xcodebuild build -scheme GreedyKit -destination 'platform=iOS Simulator,OS=${{ matrix.ios.version }},name=${{ matrix.ios.device }}' test | xcbeautify

.swiftlint.yml

@@ -18,6 +18,7 @@ opt_in_rules:
   - comment_spacing
   - force_unwrapping
   - sorted_imports
+  - void_function_in_ternary
 
 line_length: 120
 warning_threshold: 3

Package.swift

@@ -22,7 +22,10 @@ let package = Package(
         ),
         .testTarget(
             name: "GreedyKitTests",
-            dependencies: ["GreedyKit"]
+            dependencies: ["GreedyKit"],
+            resources: [
+                .process("Resources")
+            ]
         )
     ]
 )

Sources/GreedyKit/Core/Rendering/VideoRenderActor.swift → Sources/GreedyKit/Core/Rendering/VideoRenderer.swift

@@ -1,5 +1,5 @@
 //
-//  VideoRenderActor.swift
+//  VideoRenderer.swift
 //  GreedyKit
 //
 //  Created by Igor Belov on 30.06.2025.
@@ -8,7 +8,7 @@
 import AVFoundation
 import CoreImage
 
-final actor VideoRenderActor {
+final actor VideoRenderer: VideoRendererProtocol {
 
     private lazy var sampleBufferFactory = SampleBufferFactory()
     private lazy var videoOutput = AVPlayerItemVideoOutput(

Sources/GreedyKit/Core/Utils/BackedRenderView.swift

@@ -8,7 +8,7 @@
 import AVFoundation
 import UIKit
 
-final class BackedRenderView: UIView {
+final class BackedRenderView: UIView, RenderViewProtocol {
 
     // MARK: - Internal API
 

Sources/GreedyKit/Extensions/ConcurrencyShims.swift

@@ -7,8 +7,8 @@
 
 import AVFoundation
 
-/// Safe because after attachment to an `AVPlayerItem`, we only access the output's
-/// read-only methods from a single actor.
+/// Safe because after attachment to an `AVPlayerItem`,
+/// we only access the output's read-only methods from a single actor.
 /// No concurrent mutation occurs in our usage.
 extension AVPlayerItemVideoOutput: @unchecked @retroactive Sendable {}
 

Sources/GreedyKit/Extensions/BackedRenderView+Extensions.swift → Sources/GreedyKit/Extensions/RenderViewProtocol+Extensions.swift

@@ -1,13 +1,13 @@
 //
-//  UIView+Extensions.swift
+//  RenderViewProtocol+Extensions.swift
 //  GreedyKit
 //
 //  Created by Igor Belov on 05.09.2022.
 //
 
 import UIKit
 
-extension BackedRenderView {
+extension RenderViewProtocol {
     func configure(in superview: UIView) {
         translatesAutoresizingMaskIntoConstraints = false
 

Sources/GreedyKit/Helpers/DisplayLinkProtocol.swift

@@ -0,0 +1,17 @@
+//
+//  DisplayLinkProtocol.swift
+//  GreedyKit
+//
+//  Created by Igor Belov on 04.07.2025.
+//
+
+import UIKit
+
+protocol DisplayLinkProtocol: AnyObject {
+    var isPaused: Bool { get set }
+
+    func add(to runLoop: RunLoop, forMode: RunLoop.Mode)
+    func invalidate()
+}
+
+extension CADisplayLink: DisplayLinkProtocol {}

Sources/GreedyKit/Helpers/RenderViewProtocol.swift

@@ -0,0 +1,17 @@
+//
+//  RenderViewProtocol.swift
+//  GreedyKit
+//
+//  Created by Igor Belov on 04.07.2025.
+//
+
+import AVFoundation
+import UIKit
+
+protocol RenderViewProtocol: UIView {
+    var preventsCapture: Bool { get set }
+    var contentGravity: AVLayerVideoGravity { get set }
+
+    func enqueueBuffer(_ buffer: CMSampleBuffer) async
+    func clearLayer() async
+}

Sources/GreedyKit/Helpers/VideoRendererProtocol.swift

@@ -0,0 +1,13 @@
+//
+//  VideoRendererProtocol.swift
+//  GreedyKit
+//
+//  Created by Igor Belov on 04.07.2025.
+//
+
+import AVFoundation
+
+protocol VideoRendererProtocol: Sendable {
+    func attach(to item: AVPlayerItem) async
+    func frame(at time: CMTime) async -> CMSampleBuffer?
+}

Sources/GreedyKit/UIKit/GreedyPlayerView.swift

@@ -48,51 +48,75 @@ public final class GreedyPlayerView: UIView {
 
     // MARK: - Properties
 
-    private lazy var renderer = VideoRenderActor()
+    typealias DisplayLinkFactory = (
+        _ target: Any,
+        _ selector: Selector
+    ) -> DisplayLinkProtocol
 
-    private let renderView = BackedRenderView()
-    private var playerItemObserver: AnyCancellable?
+    private var displayLink: DisplayLinkProtocol?
+    private let renderer: VideoRendererProtocol
+    private let renderView: RenderViewProtocol
 
-    private lazy var displayLink = CADisplayLink(
-        target: self,
-        selector: #selector(displayLinkDidRefresh(link:))
-    )
+    private let displayLinkFactory: DisplayLinkFactory
+    private var playerItemObserver: AnyCancellable?
 
     // MARK: - Lifecycle
 
-    public override init(frame: CGRect) {
+    init(
+        frame: CGRect = .zero,
+        renderer: VideoRendererProtocol,
+        renderView: RenderViewProtocol,
+        displayLinkFactory: @escaping DisplayLinkFactory
+    ) {
+        self.renderer = renderer
+        self.renderView = renderView
+        self.displayLinkFactory = displayLinkFactory
         super.init(frame: frame)
+
         renderView.configure(in: self)
     }
 
+    public override convenience init(frame: CGRect) {
+        self.init(
+            frame: frame,
+            renderer: VideoRenderer(),
+            renderView: BackedRenderView(),
+            displayLinkFactory: { target, selector in
+                CADisplayLink(target: target, selector: selector)
+            }
+        )
+    }
+
     required init?(coder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
 
-    public override func willMove(toSuperview newSuperview: UIView?) {
-        if newSuperview == nil {
-            dismantle()
-        }
-    }
+    public override func didMoveToWindow() {
+        super.didMoveToWindow()
 
-    public override func didMoveToSuperview() {
-        super.didMoveToSuperview()
-        initializeDisplayLink()
+        if window == nil {
+            pauseRendering()
+        } else {
+            resumeRendering()
+        }
     }
 
     // MARK: - Private Methods
 
-    private func dismantle() {
-        displayLink.invalidate()
-        playerItemObserver?.cancel()
+    private func resumeRendering() {
+        if displayLink == nil {
+            displayLink = displayLinkFactory(self, #selector(displayLinkDidRefresh))
+            displayLink?.add(to: .current, forMode: .common)
+        }
+        displayLink?.isPaused = (player?.currentItem == nil)
     }
 
-    private func initializeDisplayLink() {
-        displayLink.add(to: .current, forMode: .common)
-        displayLink.isPaused = true
+    private func pauseRendering() {
+        displayLink?.invalidate()
+        displayLink = nil
     }
 
-    @objc private func displayLinkDidRefresh(link: CADisplayLink) {
+    @objc private func displayLinkDidRefresh() {
         guard let player else { return }
         let itemTime = player.currentTime()
 
@@ -104,17 +128,24 @@ public final class GreedyPlayerView: UIView {
         }
     }
 
+    private func attachAndResumeIfNeeded(_ item: AVPlayerItem) async {
+        if window != nil {
+            displayLink?.isPaused = false
+        }
+        await renderer.attach(to: item)
+    }
+
     private func addPlayerItemObserver() {
-        guard let player else { return }
+        guard let player else {
+            displayLink?.isPaused = true
+            return
+        }
 
         playerItemObserver = player.publisher(for: \.currentItem)
             .compactMap { $0 }
             .sink { [weak self] item in
                 guard let self else { return }
-                Task {
-                    await self.renderer.attach(to: item)
-                    self.displayLink.isPaused = false
-                }
+                Task { await attachAndResumeIfNeeded(item) }
             }
     }
 }