Bind viewModel to composable lifecycle#19
Closed
AntonMishanin wants to merge 1 commit intoikarenkov:masterfrom
Closed
Bind viewModel to composable lifecycle#19AntonMishanin wants to merge 1 commit intoikarenkov:masterfrom
AntonMishanin wants to merge 1 commit intoikarenkov:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a viewModelStore for each screen
When you click on back button, viewModelStore of this screen cleans their viewModels
It's works for version 0.6.4
But now it doesn't work - your click on back button - viewModel cleared and right away viewModel is creating again.
If you delete content: RendererContent value when you create ComposeRenderImpl in AppActivity and will use defaultRendererContent - it works good
I think we have a problem with content: RendererContent implementation
ScreenTransition( transitionSpec = { if (transitionType == ScreenTransitionType.Replace) { scaleIn(initialScale = 2f) + fadeIn() with fadeOut() } else { val (initialOffset, targetOffset) = when (transitionType) { ScreenTransitionType.Pop -> ({ size: Int -> -size }) to ({ size: Int -> size }) else -> ({ size: Int -> size }) to ({ size: Int -> -size }) } slideInHorizontally(initialOffsetX = initialOffset) with slideOutHorizontally(targetOffsetX = targetOffset) } } )