Skip to content

Commit 4c4f33e

Browse files
authored
Pass along options arguments (#64)
Pass along options arguments
2 parents ffa03d3 + a94255f commit 4c4f33e

File tree

4 files changed

+19
-5
lines changed

4 files changed

+19
-5
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ sudo: false
22
language: node_js
33
node_js:
44
- stable
5-
- '12.0'
5+
- '12.3'
66
- '11.0'
77
- '10.0'
88
- '9.0'

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ Module._nodeModulePaths = function (from) {
2727
}
2828

2929
var oldResolveFilename = Module._resolveFilename
30-
Module._resolveFilename = function (request, parentModule, isMain) {
30+
Module._resolveFilename = function (request, parentModule, isMain, options) {
3131
for (var i = moduleAliasNames.length; i-- > 0;) {
3232
var alias = moduleAliasNames[i]
3333
if (isPathMatchesAlias(request, alias)) {
@@ -46,7 +46,7 @@ Module._resolveFilename = function (request, parentModule, isMain) {
4646
}
4747
}
4848

49-
return oldResolveFilename.call(this, request, parentModule, isMain)
49+
return oldResolveFilename.call(this, request, parentModule, isMain, options)
5050
}
5151

5252
function isPathMatchesAlias (path, alias) {

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
"chai": "^3.5.0",
4040
"hello-world-classic": "ilearnio/hello-world-classic",
4141
"mocha": "^2.4.5",
42+
"semver": "^6.1.1",
4243
"standard": "^12.0.1"
4344
}
4445
}

test/specs.js

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,17 @@
11
/* eslint-env mocha */
2-
32
var expect = require('chai').expect
43
var exec = require('child_process').exec
54
var path = require('path')
65
var fs = require('fs')
6+
var semver = require('semver')
77
var moduleAlias
88

99
describe('module-alias', function () {
1010
beforeEach(function () { moduleAlias = require('..') })
1111

12-
afterEach(function () { moduleAlias.reset() })
12+
afterEach(function () {
13+
moduleAlias.reset()
14+
})
1315

1416
it('should register path (addPath)', function () {
1517
var value
@@ -179,6 +181,17 @@ describe('module-alias', function () {
179181
expect(bar).to.equal('Hello from baz')
180182
expect(src).to.equal('Hello from foo')
181183
})
184+
185+
if (semver.gte(process.version, '8.9.0')) {
186+
it('should support the options argument', function () {
187+
const options = {
188+
paths: [path.join(process.cwd(), 'test', 'src', 'bar')]
189+
}
190+
const baz = require.resolve('./baz', options)
191+
192+
expect(baz).to.have.string(path.join('bar', 'baz', 'index.js'))
193+
})
194+
}
182195
})
183196

184197
describe('Custom handler function', function () {

0 commit comments

Comments
 (0)