Merge pull request #57 from ilearnio/bugfix/module-alias-reset-node-11-12

Fix unit tests on node >= 11

- Also, explicitly test against node 8 through 12 + node stable in Travis CI.

Author: Kehrlann

.travis.yml

@@ -2,5 +2,10 @@ sudo: false
 language: node_js
 node_js:
   - stable
+  - '12.0'
+  - '11.0'
+  - '10.0'
+  - '9.0'
+  - '8.0'
   - '5.0'
   - '0.10'

index.js

@@ -116,6 +116,15 @@ function reset () {
   // Reset all changes in paths caused by addPath function
   modulePaths.forEach(function (path) {
     removePathHelper(path, require.main.paths)
+
+    // Delete from require.cache if the module has been required before.
+    // This is required for node >= 11
+    Object.getOwnPropertyNames(require.cache).forEach(function (name) {
+      if (name.indexOf(path) !== -1) {
+        delete require.cache[name]
+      }
+    })
+
     var parent = module.parent
     while (parent && parent !== require.main) {
       removePathHelper(path, parent.paths)

test/specs.js

@@ -107,7 +107,7 @@ describe('module-alias', function () {
       expectAliasesToBeImported()
     })
 
-    describe('with process.cwd()', function () {
+    describe('when base working directory is process.cwd()', function () {
       var baseWorkingDirectory
       beforeEach(function () {
         baseWorkingDirectory = process.cwd()
@@ -125,7 +125,7 @@ describe('module-alias', function () {
       })
     })
 
-    describe('by looking up __dirname/../../', function () {
+    describe('when module-alias package is nested (looking up __dirname/../../)', function () {
       var moduleAliasDir = path.resolve(
         '.',
         'test',