Add configuration for table name #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jack Jennings <j@ckjennin.gs>
|
Hi @jackjennings! I'll go ahead and merge this one, and do a round of testing before releasing a new gem version hopefully next week. |
|
Thanks for the timely merge, @vprigent 🙇🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At Leafly, we needed to configure a different table name for the data migrations — which we've accomplished to this point by forking the gem and adding the configuration option added in this pull request.
I'd like to get back on the mainline gem releases to get the Rails 7.1+ compatibility updates and retire our fork, but needing to change the table name prevents me from doing so.
Hopefully this looks okay, but if there are changes I can make to get this added I'd happily do so.