Skip to content

feat: Added player.PrintToHud and updated to latest css. #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Added player.PrintToHud and updated to latest css. #8

wants to merge 2 commits into from

Conversation

@T3Marius
Copy link

No description provided.

@imi-tat0r
Copy link
Owner

I like the feature but your implementation has a bunch of repeating code which I don't like

  1. CreateForAlive and CreateForDead are basically identical except for the part where you get the observerPawn, this could be one function with a bool parameter.

  2. The code for getting the pawn or the observerPawn is present in pretty much all functions. You could put that in an extra function to further clean up the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@T3Marius @imi-tat0r