Skip to content

Add debug ^4.1.1 to dependencies #1587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add debug ^4.1.1 to dependencies #1587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@
"array-includes": "^3.0.3",
"array.prototype.flat": "^1.2.1",
"contains-path": "^0.1.0",
"debug": "^2.6.9",
"debug": "^2.6.9 || ^4.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't actually keep the same node support; npm install will install debug v4, which means that it will force users to install a top-level v2 and rely on deduping to be able to get back their support. thus, this is a breaking change.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendation by NPM is to enable engine-strict option which will force v2 be installed on older node versions since debug v4 requires node v8+.
I thought this is a nice way to allow newer versions of the dependency while still having solution for older node versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's only something the top-level app can do - meaning, if the consumers of this package have to do any work whatsoever to keep the plugin working, then it's a breaking change, and that includes setting engine-strict to true (which would be a terrible idea, since "engines" is purely advisory, and should never block installs).

What's the point of a newer version tho? What do we get in v4 or v3 that we don't get in v2?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough.

The reasoning is just keeping up with latest dependencies and allow deduping.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting is a dev dep, deduping doesn’t matter; as for keeping up with the latest, that only matters if there’s something that we’re missing out on. Otherwise, it’s just capriciously breaking consumers for no good reason.

"doctrine": "1.5.0",
"eslint-import-resolver-node": "^0.3.2",
"eslint-module-utils": "^2.4.1",
Expand Down
2 changes: 1 addition & 1 deletion resolvers/node/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
},
"homepage": "https://github.com/benmosher/eslint-plugin-import",
"dependencies": {
"debug": "^2.6.9",
"debug": "^2.6.9 || ^4.1.1",
"resolve": "^1.13.1"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion resolvers/webpack/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"homepage": "https://github.com/benmosher/eslint-plugin-import/tree/master/resolvers/webpack",
"dependencies": {
"array-find": "^1.0.0",
"debug": "^2.6.9",
"debug": "^2.6.9 || ^4.1.1",
"enhanced-resolve": "^0.9.1",
"find-root": "^1.1.0",
"has": "^1.0.3",
Expand Down
4 changes: 2 additions & 2 deletions tests/src/rules/no-internal-modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,11 +116,11 @@ ruleTester.run('no-internal-modules', rule, {
],
}),
test({
code: 'import get from "debug/node"',
code: 'import get from "jquery/dist/jquery"',
filename: testFilePath('./internal-modules/plugins/plugin.js'),
errors: [
{
message: 'Reaching to "debug/node" is not allowed.',
message: 'Reaching to "jquery/dist/jquery" is not allowed.',
line: 1,
column: 17,
},
Expand Down