[BUGFIX] Prevent infinite loop when trustedProperties validation fails #1294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Thanks for your contribution. In your PR the Review and testing is fine (after adding |
If the __trustedProperties hidden property of a form is manipulated or submit as empty, the HMAC validation fails, throwing an exception. The normal exception handling then tries to forward the request to the formAction, which itself also validates the HMAC. This leads to an infinite loop which is only resolved after 100 iterations by throwing an InfiniteLoopException. This process takes time, therefore Powermail is vulnerable to DoS attacks. The change checks for a BadRequestException from the HMAC validation. In such a case, a redirect to the (then empty) formAction is performed and the error is logged. Resolves: in2code-de#1293
lorenzulrich
force-pushed
the
fix/trusted-properties-validation
branch
from
3e7410e to
1be3c18
Compare
|
@mschwemer Thanks, that is done! |
|
Please squash when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the __trustedProperties hidden property of a form is manipulated or submit as empty, the HMAC validation fails, throwing an exception.
The normal exception handling then tries to forward the request to the formAction, which itself also validates the HMAC. This leads to an infinite loop which is only resolved after 100 iterations by throwing an InfiniteLoopException.
This process takes time, therefore Powermail is vulnerable to DoS attacks.
The change checks for a BadRequestException from the HMAC validation. In such a case, a redirect to the (then empty) formAction is performed and the error is logged.
Resolves: #1293