Skip to content

Prepare EML for GBIF upload #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Prepare EML for GBIF upload #83

wants to merge 27 commits into from

Conversation

sannegovaert
Copy link
Member

This script prepares EML data extracted from IMIS for upload to a GBIF IPT.

peterdesmet
peterdesmet requested changes Sep 18, 2024
View reviewed changes
@peterdesmet
Copy link
Member

I also think it's best to remove the external link to IMIS (like https://www.vliz.be/en/imis?dasid=5867) as part of this script, since we have the DOI pointing to the same thing.

@peterdesmet
Copy link
Member

And I would remove all emails of all creators/contacts, since there are still some odd emails there. ORCID is sufficient.

peterdesmet
peterdesmet requested changes Jan 24, 2025
View reviewed changes
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The last paragraph in the description (that is added with our write_eml() function) has escaped HTML characters. I think we should wrap that in <![CDATA[.

@sannegovaert
Copy link
Member Author

sannegovaert commented Mar 31, 2025 •
edited
Loading

I updated the script so to wrap more paragraphs with <![CDATA[.
It seems that more metadata is added from IMIS. I do not understand why pubdate is going back in time however.

(I forgot about this issue)

peterdesmet
peterdesmet requested changes Apr 1, 2025
View reviewed changes
Copy link
Member

@peterdesmet peterdesmet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last paragraph &lt;![CDATA[ has escaped characters, rather than <![CDATA[. I don't think this will work in IPT import. 😬

@sannegovaert
reorder CDATA wrap code
bb52392
@sannegovaert
update to EML 2.2.0
c0a2b40 
- ![CDATA[ ]]> wrappers are not needed anymore
- lists of paragraphs ara replaced by <p></p> tags
@sannegovaert
Copy link
Member Author

sannegovaert commented Apr 2, 2025 •
edited
Loading

As we discussed and tested yesterday on the IPT:

  • <![CDATA[ ]]> wrappers are not needed anymore
  • lists of paragraphs can be replaced by <p></p> tags

@sannegovaert
split in paragraphs and add <p></p> tags
0c085c1 
Sometimes the <p></p> tags are missing in the source eml. This solves that problem.
@sannegovaert
typo
737a7fc
@sannegovaert sannegovaert requested a review from peterdesmet April 2, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterdesmet peterdesmet Awaiting requested review from peterdesmet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sannegovaert @peterdesmet