💣 Correction des tests d'intégration suite à une mise à jour de Playwright (#1755)

fabienheureux · fabienheureux · commit 40432b33d92e · 2025-07-02T10:18:30.000+02:00
* 🎨 Revue des suggestions en homepage et boutons de partage (+ ajout de django Lookbook) (#1728) * Fix fixtures installation * Rename and comment * Rename * Add proposition service fixture * Fix selector * Update selector * Fixtures * Missing proposition services * Missing proposition services * Rollback precommit changes * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Update fixtures... * Fix fixtures * Fix this * Skip digital acteurs * Fix formulaire test * Disable test for now * Click on svg explicitely * Click on svg explicitely * Add docstring * Ignore file * Test * Add basic config * redirect http to https locally * wip * Remove sidebar * Add share / embed buttons * Improve spacing * Improve alignment on homepage * Add icon to footer * Missing produit * Add comment * Retours Delphine * Update wordings * WIP * 🇫🇷 Utiliser le header du DSFR (#1737) * Fix fixtures installation * Rename and comment * Rename * Add proposition service fixture * Fix selector * Update selector * Fixtures * Missing proposition services * Missing proposition services * Rollback precommit changes * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Fix fixtures * Update fixtures... * Fix fixtures * Fix this * Skip digital acteurs * Fix formulaire test * Disable test for now * Click on svg explicitely * Click on svg explicitely * Add docstring * Ignore file * Test * Add basic config * redirect http to https locally * wip * Remove sidebar * Add share / embed buttons * Improve spacing * Improve alignment on homepage * Add icon to footer * Missing produit * Add comment * Retours Delphine * Update wordings * WIP * Add header * WIP * Improve patchwork spacing * add contactez nous menu item * Use main menu instead * Use main menu * Add loupe in header * 🪄 Ajout de rendering conditionnel selon qu'on soit dans une iframe ou non (#1738) * Fix fixtures installation * ename and comment * Rename * Fix selector * Fixtures * Missing proposition services * Disable test for now * Click on svg explicitely * Ignore file * Test * Add basic config * redirect http to https locally * wip * Remove sidebar * Add share / embed buttons * Improve spacing * Improve alignment on homepage * Add icon to footer * Missing produit * Add comment * Retours Delphine * Update wordings * WIP * Add header * WIP * Improve patchwork spacing * add contactez nous menu item * Use main menu instead * Use main menu * Add loupe in header * add conditionnal rendering * missing querystring * WIP * Improve querystring navigation * wip * WIP * Add iframe field to search form to customize links * Rely on session storage instead * Remove setting * WIP * Better persist querystring accross navigation * Better persist querystring accross navigation * cleanup * 🗑️ Suppression de Uvicorn des dépendances (#1754) * 🗑️ Suppression de Uvicorn des dépendances * Lockfile * fix tests * Fix formulaire test * Fix e2e * Fix e2e
diff --git a/.secrets.baseline b/.secrets.baseline
@@ -90,6 +90,10 @@
     {
       "path": "detect_secrets.filters.allowlist.is_line_allowlisted"
     },
+    {
+      "path": "detect_secrets.filters.common.is_baseline_file",
+      "filename": ".secrets.baseline"
+    },
     {
       "path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",
       "min_level": 2
@@ -138,7 +142,7 @@
         "filename": "core/settings.py",
         "hashed_secret": "1ee34e26aeaf89c64ecc2c85efe6a961b75a50e9",
         "is_verified": false,
-        "line_number": 291
+        "line_number": 290
       }
     ],
     "dbt/package-lock.yml": [
@@ -187,5 +191,5 @@
       }
     ]
   },
-  "generated_at": "2025-06-23T18:57:14Z"
+  "generated_at": "2025-07-02T08:18:24Z"
 }
diff --git a/e2e_tests/accessibility.spec.ts b/e2e_tests/accessibility.spec.ts
@@ -48,6 +48,10 @@ test.describe("WCAG Compliance Tests", () => {
 
     const accessibilityScanResults = await new AxeBuilder({ page })
       .exclude("[data-disable-axe]")
+      // ImpactCO2 iframe does not load during e2e tests, it is safe
+      // to exclude it usually includes a title and is a valid <iframe>
+      // tag.
+      .exclude('iframe[src*="impactco2.fr"]')
       .withTags(WCAG_TAGS)
       .analyze()
 
diff --git a/e2e_tests/advanced_filters.spec.ts b/e2e_tests/advanced_filters.spec.ts
@@ -1,43 +1,55 @@
 import { expect, test } from "@playwright/test"
 import { hideDjangoToolbar } from "./helpers"
 
-async function searchInCarteMode(page){
+async function searchInCarteMode(page) {
   await page.locator("input#id_adresse").click()
   await page.locator("input#id_adresse").fill("Paris")
-  await page.locator("#id_adresseautocomplete-list.autocomplete-items div:nth-of-type(2)").click()
+  await page
+    .locator("#id_adresseautocomplete-list.autocomplete-items div:nth-of-type(2)")
+    .click()
 }
 
-async function openAdvancedFilters(page, dataTestId="advanced-filters") {
+async function openAdvancedFilters(page, dataTestId = "advanced-filters") {
   // Explicitely wait for addresses to load
-  await page.waitForTimeout(5000);
+  await page.waitForTimeout(5000)
   await page.locator(`button[data-testid=${dataTestId}]`).click()
-  await expect(page.locator("[data-testid=advanced-filters-modal] .fr-modal__content h2")).toBeInViewport()
-  await page.locator("[data-testid=advanced-filters-modal] .fr-modal__header button").click()
-  await expect(page.locator("[data-testid=advanced-filters-modal] .fr-modal__content h2")).toBeHidden()
+  await expect(
+    page.locator("[data-testid=advanced-filters-modal] .fr-modal__content h2"),
+  ).toBeInViewport()
+  await page
+    .locator("[data-testid=advanced-filters-modal] .fr-modal__header button")
+    .click()
+  await expect(
+    page.locator("[data-testid=advanced-filters-modal] .fr-modal__content h2"),
+  ).toBeHidden()
 }
 
 test("Filtres avancés s'ouvrent et se ferment en mode formulaire", async ({ page }) => {
-    await page.goto(`/formulaire`, {
-        waitUntil: "networkidle",
-    })
-    await hideDjangoToolbar(page)
-    await openAdvancedFilters(page)
+  await page.goto(`/formulaire`, {
+    waitUntil: "domcontentloaded",
+  })
+  await hideDjangoToolbar(page)
+  await openAdvancedFilters(page)
 })
 
-test("Desktop | Filtres avancés s'ouvrent et se ferment en mode carte", async ({ page }) => {
-    await page.goto(`/carte`, {
-        waitUntil: "networkidle",
-    })
-    await hideDjangoToolbar(page)
-    await searchInCarteMode(page)
-    await openAdvancedFilters(page, "advanced-filters-in-legend")
+test("Desktop | Filtres avancés s'ouvrent et se ferment en mode carte", async ({
+  page,
+}) => {
+  await page.goto(`/carte`, {
+    waitUntil: "domcontentloaded",
+  })
+  await hideDjangoToolbar(page)
+  await searchInCarteMode(page)
+  await openAdvancedFilters(page, "advanced-filters-in-legend")
 })
 
-test("Mobile | Filtres avancés s'ouvrent et se ferment en mode carte", async ({ page }) => {
-    await page.goto(`/carte`, {
-        waitUntil: "networkidle",
-    })
-    await hideDjangoToolbar(page)
-    await searchInCarteMode(page)
-    await openAdvancedFilters(page)
+test("Mobile | Filtres avancés s'ouvrent et se ferment en mode carte", async ({
+  page,
+}) => {
+  await page.goto(`/carte`, {
+    waitUntil: "domcontentloaded",
+  })
+  await hideDjangoToolbar(page)
+  await searchInCarteMode(page)
+  await openAdvancedFilters(page)
 })
diff --git a/e2e_tests/assistant.spec.ts b/e2e_tests/assistant.spec.ts
@@ -16,7 +16,7 @@ async function searchOnProduitPage(page, searchedAddress: string) {
 
 test("Desktop | La carte s'affiche sur une fiche déchet/objet", async ({ page }) => {
   // Navigate to the carte page
-  await page.goto(`/dechet/lave-linge`, { waitUntil: "networkidle" })
+  await page.goto(`/dechet/lave-linge`, { waitUntil: "domcontentloaded" })
   // await hideDjangoToolbar(page)
   await searchOnProduitPage(page, "Auray")
   const sessionStorage = await page.evaluate(() => window.sessionStorage)
@@ -27,23 +27,23 @@ test("Desktop | La carte s'affiche sur une fiche déchet/objet", async ({ page }
 
 test("Desktop | Le tracking PostHog fonctionne comme prévu", async ({ page }) => {
   // Check that homepage scores 1
-  await page.goto(`/`, { waitUntil: "networkidle" })
+  await page.goto(`/`, { waitUntil: "domcontentloaded" })
   // await hideDjangoToolbar(page)
   let sessionStorage = await page.evaluate(() => window.sessionStorage)
   expect(sessionStorage.homePageView).toBe("0")
 
   // Navigate to a produit page and check that it scores 1
-  await page.goto(`/dechet/lave-linge`, { waitUntil: "networkidle" })
+  await page.goto(`/dechet/lave-linge`, { waitUntil: "domcontentloaded" })
   sessionStorage = await page.evaluate(() => window.sessionStorage)
   expect(sessionStorage.produitPageView).toBe("1")
 
   // Click on a pin on the map and check that it scores 1
   await searchOnProduitPage(page, "Auray")
-  const markers = page.locator(".leaflet-marker-icon")
   // Remove the home marker (red dot) that prevents Playwright from clicking other markers
   await page.evaluate(() => {
     document.querySelector(".leaflet-marker-icon.home-icon")?.remove()
   })
+  const markers = page.locator(".leaflet-marker-icon")
 
   // Ensure we have at least one marker, and let's click on a marker.
   // The approach is feels cumbersome, this is because Playwright has a
@@ -89,7 +89,7 @@ test("Desktop | Le tracking PostHog fonctionne comme prévu", async ({ page }) =
 
   // Ensure that the scores does not increases after
   // several homepage visits
-  await page.goto(`/`, { waitUntil: "networkidle" })
+  await page.goto(`/`, { waitUntil: "domcontentloaded" })
   sessionStorage = await page.evaluate(() => window.sessionStorage)
   expect(sessionStorage.homePageView).toBe("0")
 })
diff --git a/e2e_tests/browser_version.spec.ts b/e2e_tests/browser_version.spec.ts
@@ -1,19 +1,19 @@
 import { expect, test } from "@playwright/test"
 
 test("Browser version alert is not displayed", async ({ page }) => {
-    await page.goto(`/formulaire`, { waitUntil: "networkidle" })
+  await page.goto(`/formulaire`, { waitUntil: "domcontentloaded" })
 
-    const titlePage = await page.title()
-    expect(titlePage).toBe("Longue vie aux objets")
+  const titlePage = await page.title()
+  expect(titlePage).toBe("Longue vie aux objets")
 
-    // Check that the browser version alert is not displayed
-    const alert = await page.$("#obsolete_browser_message")
-    expect(await alert?.getAttribute("class")).toContain("qf-hidden")
+  // Check that the browser version alert is not displayed
+  const alert = await page.$("#obsolete_browser_message")
+  expect(await alert?.getAttribute("class")).toContain("qf-hidden")
 
-    // check libelé "L'application nécessite Javascript pour être exécutée correctement" is inside a noscript tag
-    const noscript = await page.$("noscript")
-    const noscriptContent = await noscript?.textContent()
-    expect(noscriptContent).toContain(
-        "L'application nécessite Javascript pour être exécutée correctement",
-    )
+  // check libelé "L'application nécessite Javascript pour être exécutée correctement" is inside a noscript tag
+  const noscript = await page.$("noscript")
+  const noscriptContent = await noscript?.textContent()
+  expect(noscriptContent).toContain(
+    "L'application nécessite Javascript pour être exécutée correctement",
+  )
 })
diff --git a/e2e_tests/carte.spec.ts b/e2e_tests/carte.spec.ts
@@ -1,14 +1,14 @@
-import { expect, test } from "@playwright/test";
-import { hideDjangoToolbar, searchDummyAdresse } from "./helpers";
+import { expect, test } from "@playwright/test"
+import { hideDjangoToolbar, searchDummyAdresse } from "./helpers"
 
 test("Desktop | La carte affiche la légende après une recherche", async ({ page }) => {
-    // Navigate to the carte page
-    await page.goto(`/carte`, { waitUntil: "networkidle" });
-    await hideDjangoToolbar(page)
+  // Navigate to the carte page
+  await page.goto(`/carte`, { waitUntil: "domcontentloaded" })
+  await hideDjangoToolbar(page)
 
-    await expect(page.getByTestId("carte-legend")).toBeHidden()
+  await expect(page.getByTestId("carte-legend")).toBeHidden()
 
-    // Fill "Adresse" autocomplete input
-    await searchDummyAdresse(page)
-    await expect(page.getByTestId("carte-legend")).toBeVisible()
+  // Fill "Adresse" autocomplete input
+  await searchDummyAdresse(page)
+  await expect(page.getByTestId("carte-legend")).toBeVisible()
 })
diff --git a/e2e_tests/iframe.spec.ts b/e2e_tests/iframe.spec.ts
diff --git a/e2e_tests/iframe/action_list.spec.ts b/e2e_tests/iframe/action_list.spec.ts
diff --git a/e2e_tests/search_update.spec.ts b/e2e_tests/search_update.spec.ts

Original file line number	Diff line number	Diff line change
`@@ -90,6 +90,10 @@`
`90`	`90`	`{`
`91`	`91`	`"path": "detect_secrets.filters.allowlist.is_line_allowlisted"`
`92`	`92`	`},`
	`93`	`+ {`
	`94`	`+ "path": "detect_secrets.filters.common.is_baseline_file",`
	`95`	`+ "filename": ".secrets.baseline"`
	`96`	`+ },`
`93`	`97`	`{`
`94`	`98`	`"path": "detect_secrets.filters.common.is_ignored_due_to_verification_policies",`
`95`	`99`	`"min_level": 2`
`@@ -138,7 +142,7 @@`
`138`	`142`	`"filename": "core/settings.py",`
`139`	`143`	`"hashed_secret": "1ee34e26aeaf89c64ecc2c85efe6a961b75a50e9",`
`140`	`144`	`"is_verified": false,`
`141`		`- "line_number": 291`
	`145`	`+ "line_number": 290`
`142`	`146`	`}`
`143`	`147`	`],`
`144`	`148`	`"dbt/package-lock.yml": [`
`@@ -187,5 +191,5 @@`
`187`	`191`	`}`
`188`	`192`	`]`
`189`	`193`	`},`
`190`		`- "generated_at": "2025-06-23T18:57:14Z"`
	`194`	`+ "generated_at": "2025-07-02T08:18:24Z"`
`191`	`195`	`}`