Corrige une régression sur les cartes sur mesure sans sous-catégorie définie (#1949)

Author: fabienheureux

integration_tests/carte/test_use_carte_config.py

@@ -64,3 +64,26 @@ def test_preview_screen(self, get_carte_config_response_and_soup):
         assert (
             soup.find(attrs={"data-testid": "preview-content"}).text.strip() == "Coucou"
         )
+
+    def test_cyclevia_regresion(self, get_carte_config_response_and_soup):
+        """A regression introduced by adding the CarteConfig as a wagtail block
+        caused the Cyclevia CarteConfig to fail after a search, because it does
+        not use any sous_categorie_objet.
+        This test ensures that the regression is fixed."""
+        carte_config_without_sous_categories = CarteConfigFactory()
+        response, soup = get_carte_config_response_and_soup(
+            carte_config_without_sous_categories.slug,
+            {
+                "adresse": "Auray",
+                "longitude": "-2.990838",
+                "latitude": "47.668099",
+                "carte": "",
+                "r": "55",
+                "bounding_box": "",
+                "direction": "",
+                "action_displayed": "trier",
+                "sous_categorie_objet": "",
+                "sc_id": "",
+            },
+        )
+        assert response.status_code == 200

qfdmo/views/carte.py

@@ -107,11 +107,14 @@ def _grouped_action_from(self, *args, **kwargs):
         return super()._grouped_action_from(*args, **kwargs)
 
     def get_sous_categorie_filter(self):
-        # TODO: Revoir nommage + documenter
-        if sous_categorie_filter := self.request.GET.getlist(
-            CarteConfig.SOUS_CATEGORIE_QUERY_PARAM
-        ):
-            return sous_categorie_filter
+        sous_categories_from_request = list(
+            filter(
+                None, self.request.GET.getlist(CarteConfig.SOUS_CATEGORIE_QUERY_PARAM)
+            )
+        )
+        if sous_categories_from_request:
+            return sous_categories_from_request
+
         return self.get_object().sous_categorie_objet.all().values_list("id", flat=True)
 
     def _compile_acteurs_queryset(self, *args, **kwargs):