Remove unnecessary code and refactor request handling

The changes clean up redundant code and simplify request parameter
handling by directly using request.GET instead of a wrapper method.

Author: fabienheureux

qfdmo/views/adresses.py

@@ -105,25 +105,23 @@ def get_sous_categorie_objet(self) -> str:
 
     def get_sc_id(self, initial) -> str | None:
         return (
-            self.get_data_from_request_or_bounded_form("sc_id")
-            if initial["sous_categorie_objet"]
-            else None
+            self.request.GET.get("sc_id") if initial["sous_categorie_objet"] else None
         )
 
     def get_sous_categories_ids(self) -> list[int]:
         return [self.get_data_from_request_or_bounded_form("sc_id", 0)]
 
     def get_adresse(self) -> str:
-        return self.get_data_from_request_or_bounded_form("adresse")
+        return self.request.GET.get("adresse")
 
     def get_longitude(self) -> str:
-        return self.get_data_from_request_or_bounded_form("longitude")
+        return self.request.GET.get("longitude")
 
     def get_latitude(self) -> str:
-        return self.get_data_from_request_or_bounded_form("latitude")
+        return self.request.GET.get("latitude")
 
     def get_digital(self) -> str:
-        return self.get_data_from_request_or_bounded_form("digital", "0")
+        return self.request.GET.get("digital", "0")
 
     def get_data_from_request_or_bounded_form(self, key: str, default=None):
         """Temporary dummy method
@@ -248,8 +246,6 @@ def get_context_data(self, **kwargs):
         kwargs.update(
             # TODO: refacto forms : define a BooleanField carte on CarteAddressesForm
             carte=self.is_carte,
-            # TODO: refacto forms, return bounded form in template
-            # form=form,
             location="{}",
         )
 

qfdmo/views/carte.py

@@ -16,9 +16,6 @@ class CarteSearchActeursView(SearchActeursView):
     template_name = "qfdmo/carte.html"
     form_class = CarteForm
 
-    def __init__(self, *args, **kwargs):
-        super().__init__(*args, **kwargs)
-
     def get_initial(self, *args, **kwargs):
         initial = super().get_initial(*args, **kwargs)
         action_displayed = self._set_action_displayed()
@@ -37,6 +34,7 @@ def get_initial(self, *args, **kwargs):
 
     def get_context_data(self, **kwargs):
         self.displayed_acteur_form = DisplayedActeursForm(self.request.GET)
+
         if not self.displayed_acteur_form.is_valid():
             logger.error(f"Form is valid {self.displayed_acteur_form=}")
 
@@ -58,7 +56,7 @@ def get_sous_categories(self):
         ):
             return sous_categories.values_list("pk", flat=True)
 
-        return []
+    #     return super().get_sous_categories()
 
 
 class ProductCarteView(CarteSearchActeursView):
@@ -78,11 +76,6 @@ class CustomCarteView(DetailView, CarteSearchActeursView):
     model = CarteConfig
     context_object_name = "carte_config"
 
-    def get_context_data(self, *args, **kwargs):
-        ctx = super().get_context_data(*args, **kwargs)
-
-        return ctx
-
     @cached_property
     def groupe_actions(self):
         # TODO: cache