Better handle missing svg error

Author: fabienheureux

qfdmd/middleware.py

@@ -14,7 +14,7 @@ def __call__(self, request):
     def _set_logged_in_cookie(self, request, response):
         """Set or update the 'logged-in' header based on authentication."""
         cookie_name = "logged_in"
-        if request.user.is_authenticated:
+        if hasattr(request, "user") and request.user.is_authenticated:
             response.set_cookie(cookie_name, "1")
         elif request.COOKIES.get(cookie_name):
             response.delete_cookie(cookie_name)

qfdmd/templatetags/qfdmd_tags.py

@@ -1,4 +1,5 @@
 from typing import cast
+import logging
 
 from django import template
 from django.conf import settings
@@ -7,6 +8,7 @@
 from django.utils.safestring import mark_safe
 
 register = template.Library()
+logger = logging.getLogger(__name__)
 
 
 @register.inclusion_tag("components/patchwork/patchwork.html")
@@ -26,16 +28,24 @@ def render_file_content(file_field: FileField) -> str:
     """Renders the content of a Filefield as a safe HTML string
     and caches the result."""
 
-    def get_file_content() -> str:
-        with file_field.open() as f:
-            return mark_safe(f.read().decode("utf-8"))  # noqa: S308
+    try:
 
-    return cast(
-        str,
-        cache.get_or_set(
-            f"filefield-{file_field.name}-{file_field.size}", get_file_content
-        ),
-    )
+        def get_file_content() -> str:
+            with file_field.open() as f:
+                return mark_safe(f.read().decode("utf-8"))  # noqa: S308
+
+        return cast(
+            str,
+            cache.get_or_set(
+                f"filefield-{file_field.name}-{file_field.size}", get_file_content
+            ),
+        )
+    except FileNotFoundError as exception:
+        # We silent the error here to prevent crashing a page for a missing svg
+        logger.warning("An error was quietly ignored")
+        logger.error(exception)
+
+        return ""
 
 
 @register.inclusion_tag("head/favicon.html")