-
Notifications
You must be signed in to change notification settings - Fork 5
🌆 [ENRICH] BAN: villes anciennes -> nouvelles #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27f850f
to
cc0d305
Compare
4522f78
to
2f1a4e3
Compare
e106fc0
to
ba49c98
Compare
21a04b0
to
40f02e4
Compare
maxcorbeau
commented
Apr 21, 2025
09afc1d
to
b233cf2
Compare
9e40459
to
abfe6cf
Compare
dca5e56
to
947e530
Compare
abfe6cf
to
8fa0d32
Compare
kolok
approved these changes
Apr 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quelques commentaires non bloquants
b13ca01
to
8df023d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌆 BAN: villes anciennes -> nouvelles
🗺️ contexte: les villes en France qui changent de nom
💡 quoi: un DAG pour convertir les anciennes vers nouvelles villes
🎯 pourquoi: aligner vs. réalité + aider au clustering
🤔 comment:
ville_ancienne
pour affichier sur la carte ?🖼️ Exemple
Cohorte de variations ortographiques:

Cohorte de ville ancienne -> nouvelle

🔴 Problème
dbt
Peut-être suis-je fatigué, mais je ne comprends pas le comportement de mon
dbt
: quand je build un des 2 modèles, il me supprime l'autre. Pourtant dans les logs dbt je ne vois q'1 DROP sur le modèle en cours de buildEn fin de script je m'attendrais à avoir 2 vues:
public.marts_enrich_acteurs_villes_suggest_typo
public.marts_enrich_acteurs_villes_suggest_new
📆 Prochaines PRs