Support du suffixe pour les acteurs digitaux par les identifiant_externes #1561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kolok
force-pushed
the
gestion_duplicates_in_mapping
branch
from
0c276b6 to
b254407
Compare
kolok
force-pushed
the
gestion_duplicates_in_mapping_index
branch
from
d9230eb to
cdd9f83
Compare
kolok
requested review from
fabienheureux and
maxcorbeau
and removed request for
a team
Comment on lines
+13
to
+15
| not acteur.identifiant_externe.endswith("_d") | ||
| and acteur.identifiant_unique.endswith("_d") | ||
| and acteur.identifiant_externe in acteur.identifiant_unique |
There was a problem hiding this comment.
Comment on lines
+17
to
+18
| acteur.identifiant_externe = f"{acteur.identifiant_externe}_d" | ||
| acteur.save() |
There was a problem hiding this comment.
fabienheureux
approved these changes
Apr 28, 2025
kolok
force-pushed
the
gestion_duplicates_in_mapping
branch
from
b254407 to
e8540d9
Compare
Co-authored-by: Fabien Le Frapper <contact@fabienlefrapper.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Suite #1521
Notion : Importer le fichier v3 Valdelia (EA, PMCB) dans LVAO - avec table de pivot vers nouvel ID
🗺️ contexte: Airflow - Source
💡 quoi: Ajouter une contrainte d'unicité sur le couple source, identifiant_externe pour les acteurs actifs
🎯 pourquoi: Permettre de se reposer sur ce couple pour identifier les acteurs à mettre à jour
🤔 comment:
Exemple résultats / UI / Data
Auto-review
Les trucs à faire avant de demander une review :
.env.template✅ Reste à faire (PR en cours)
📆 A faire (prochaine PR)