Skip to content

Conversation

kolok
Copy link
Contributor

@kolok kolok commented May 7, 2025

Description succincte du problème résolu

Github : suite de #1574

🗺️ contexte: DB

💡 quoi: Isolé tous les modèles utilisé par DBT dans un schema à part warehouse

🎯 pourquoi: Diviser les cas d'utilisation, permettra par la suite d'utiliser des base de données différente si warehouse surcharge la base de données et permet de ne pas copier le schema `warehouse lors de la copie de la base de données

🤔 comment:

  • déclaration d'un schéma warehouse
  • configuration de la copy pour ne copier que le schema public

Auto-review

Les trucs à faire avant de demander une review :

  • J'ai bien relu mon code
  • La CI passe bien
  • En cas d'ajout de variable d'environnement, j'ai bien mis à jour le .env.template
  • J'ai ajouté des tests qui couvrent le nouveau code

✅ Reste à faire (PR en cours)

📆 A faire (prochaine PR)

@kolok kolok added the technical label May 7, 2025
@kolok kolok force-pushed the ae_replaced_dont_create_parent branch from a7232d3 to cbc1e64 Compare May 7, 2025 11:45
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch 7 times, most recently from 8e8261d to 4315a77 Compare May 12, 2025 16:30
@kolok kolok marked this pull request as ready for review May 12, 2025 16:42
@kolok kolok requested a review from a team as a code owner May 12, 2025 16:42
@kolok kolok requested review from fabienheureux and removed request for a team May 12, 2025 16:42
@kolok kolok force-pushed the ae_replaced_dont_create_parent branch from bb96dfa to 57957cd Compare May 14, 2025 08:36
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch from 4315a77 to 212662e Compare May 14, 2025 08:38
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch from 212662e to 01b7cfa Compare May 14, 2025 08:51
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch from 01b7cfa to 6997558 Compare May 14, 2025 09:00
Base automatically changed from ae_replaced_dont_create_parent to main May 15, 2025 11:30
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch from b94acae to 6760558 Compare May 15, 2025 11:32
@kolok kolok force-pushed the ae_replaced_dont_create_parent_schema branch from df7d20d to 8a6ca80 Compare May 15, 2025 13:32
@kolok kolok enabled auto-merge (squash) May 15, 2025 13:33
@kolok kolok merged commit ff1a3f3 into main May 15, 2025
8 of 11 checks passed
@kolok kolok deleted the ae_replaced_dont_create_parent_schema branch May 15, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants