-
Notifications
You must be signed in to change notification settings - Fork 5
Ajout du backlink sur les iframes de l'assistant #1950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
fabienheureux
wants to merge
9
commits into
main
Choose a base branch
from
add-backlink-on-iframes
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
9ab807c
WIP - Ajout du backlink
fabienheureux 8749929
Add contrib
fabienheureux f3bb54e
Make backlink editable
fabienheureux 6240311
Merge branch 'main' into add-backlink-on-iframes
fabienheureux 4bbf354
Add to formulaire and carte
fabienheureux 1efc312
Add to formulaire and carte
fabienheureux 76bfad8
Merge branch 'main' into add-backlink-on-iframes
fabienheureux 7e55e22
Merge branch 'main' into add-backlink-on-iframes
fabienheureux b22caeb
Apply suggestion from @fabienheureux
fabienheureux File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,49 @@ | ||
# Generated by Django 5.2.5 on 2025-09-11 11:34 | ||
|
||
import wagtail.fields | ||
from django.db import migrations, models | ||
|
||
|
||
class Migration(migrations.Migration): | ||
|
||
dependencies = [ | ||
("qfdmd", "0056_alter_produitpage_body"), | ||
] | ||
|
||
operations = [ | ||
migrations.CreateModel( | ||
name="EmbedSettings", | ||
fields=[ | ||
( | ||
"id", | ||
models.BigAutoField( | ||
auto_created=True, | ||
primary_key=True, | ||
serialize=False, | ||
verbose_name="ID", | ||
), | ||
), | ||
( | ||
"backlink_assistant", | ||
wagtail.fields.RichTextField( | ||
verbose_name="Backlink de l'iframe de l'assistant" | ||
), | ||
), | ||
( | ||
"backlink_carte", | ||
wagtail.fields.RichTextField( | ||
verbose_name="Backlink de l'iframe de la carte" | ||
), | ||
), | ||
( | ||
"backlink_formulaire", | ||
wagtail.fields.RichTextField( | ||
verbose_name="Backlink de l'iframe du formulaire" | ||
), | ||
), | ||
], | ||
options={ | ||
"verbose_name": "Réglage des iframes", | ||
}, | ||
), | ||
] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
export type BacklinkKey = "assistant" | "carte" | "formulaire" | ||
export async function generateBackLink(iframe: HTMLIFrameElement, key: BacklinkKey) { | ||
const backlinkTag = document.createElement("div") | ||
backlinkTag.setAttribute( | ||
"style", | ||
"font-size: 0.9rem; text-align: center; padding-top: 0.5rem;", | ||
) | ||
const backlinkContent = await fetch(`${origin}/embed/backlink?key=${key}`) | ||
backlinkTag.innerHTML = await backlinkContent.text() | ||
iframe.insertAdjacentElement("afterend", backlinkTag) | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,3 +1,5 @@ | ||||||
import { BacklinkKey } from "../embed/helpers" | ||||||
|
||||||
function compileIframeAttributes( | ||||||
baseUrl: string, | ||||||
urlParams: URLSearchParams, | ||||||
|
@@ -30,8 +32,10 @@ export function buildAndInsertIframeFrom( | |||||
iframeAttributes: object, | ||||||
iframeExtraAttributes: object, | ||||||
scriptTag: HTMLScriptElement, | ||||||
backlinkKey: BacklinkKey, | ||||||
) { | ||||||
const iframe = document.createElement("iframe") | ||||||
await generateBackLink(iframe, key) | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
? |
||||||
for (var key in iframeAttributes) { | ||||||
iframe.setAttribute(key, iframeAttributes[key]) | ||||||
} | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.