Skip to content

Conversation

GllmR
Copy link
Contributor

@GllmR GllmR commented Sep 4, 2025

Ces modifications permettent d'ajouter une étape sans remplir la date afin que les porteurs puissent créer leur projet même si la convention n'est pas encore signée.

Elle apporte également des modifications sur le style et les labels dans le formulaire :

  • Ajout de bordures pour bien séparer la partie en édition du reste du formulaire
  • Modification des labels pour les boutons pour clarifier les actions

@GllmR GllmR requested a review from Copilot September 4, 2025 14:51
@GllmR GllmR self-assigned this Sep 4, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the requirement for dates in timeline steps, allowing project creators to add steps without specifying dates when conventions aren't yet signed. The changes also improve form styling and button labels for better user experience.

  • Removed date requirement validation for timeline steps
  • Added visual borders to form components to separate editing sections
  • Updated button labels to be more descriptive and clarify actions

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
components/ui/timeline-step.js Shows fallback message when step date is not provided
components/suivi-form/etapes.js Removes date requirement and simplifies step form layout
backend/lib/projets-validator.js Allows empty/null dates in validation
components/suivi-form/subventions/subvention-form.js Adds visual styling and updates button label
components/suivi-form/reutilisations/reutilisation-form.js Adds visual styling and updates button label
components/suivi-form/perimetres/perimetre-form.js Adds visual styling and updates button label
components/suivi-form/livrables/livrable-form.js Adds visual styling and updates button label
components/suivi-form/acteurs/acteur-form.js Adds visual styling and updates button label

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@GllmR GllmR merged commit 8fd7746 into main Sep 4, 2025
1 check passed
@GllmR GllmR deleted the fix/etapes branch September 4, 2025 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant