Add insert_sorted_by{,_key} methods for map/set
#402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
requested changes
Jul 14, 2025
| /// | ||
| /// This is equivalent to finding the position with | ||
| /// [`binary_search_by`][Self::binary_search_by], then calling | ||
| /// [`insert_before`][Self::insert_before] for a new key. |
There was a problem hiding this comment.
The insertion call is not just for new keys.
Suggested change
| /// [`insert_before`][Self::insert_before] for a new key. | |
| /// [`insert_before`][Self::insert_before] with the given key and value. |
| /// | ||
| /// This is equivalent to finding the position with | ||
| /// [`binary_search_by_key`][Self::binary_search_by_key] with `cmp(key)`, then | ||
| /// calling [`insert_before`][Self::insert_before] for a new key. |
There was a problem hiding this comment.
Suggested change
| /// calling [`insert_before`][Self::insert_before] for a new key. | |
| /// calling [`insert_before`][Self::insert_before] with the given key and value. |
| /// | ||
| /// If the sorted item is found in the set, it returns the index of that | ||
| /// existing item and `false`. Otherwise, it inserts the new item and | ||
| /// returns its sorted index and `true`. |
There was a problem hiding this comment.
This paragraph needs adjustment because existing items also move -- or maybe just leave it out like you did with the map method.
| /// | ||
| /// If the sorted item is found in the set, it returns the index of that | ||
| /// existing item and `false`. Otherwise, it inserts the new item and | ||
| /// returns its sorted index and `true`. |
There was a problem hiding this comment.
Same here, either update or remove this paragraph.
Comment on lines
+1237
to
+1238
| let values: Vec<_> = map.iter().map(|(k,v)|(*k,*v)).collect(); | ||
| map.sort_by_cached_key(|key, _| key.abs()); |
There was a problem hiding this comment.
I think it would be better for this to sort the original values as a more independent check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #401.