wrong rendering for span p-author

[JOduMonT]

After activating the last version (1.1.0) of your plugin on WordPress 4.9.8 with understrap theme
my meta entry become : Posted on September 12, 2018 by <span class='p-author h-card'>Author</span>
instead of : Posted on September 12, 2018 by Author
for fun I look into the code and I think the error is here
but since I'm totally not a PHP developer I'll pass on the potential PR

[pfefferle]

This is a problem if themes escape the output... the problem is not the code you referenced, but here:

wordpress-uf2/includes/class-uf2-author.php

Line 20 in 66fef5f

return "<span class='p-author h-card'>$author</span>";

I am working on a different solution, that should solve the problem in the future: https://github.com/indieweb/wordpress-mf2-feed

For now I would recommend to disable the plugin. I will also try to remove it from the IndieWeb plugin.

[pfefferle]

@miklb feel free to take over the plugin.

[miklb]

I’ve already forked it. Cheers, Michael

…

On Sep 13, 2018, 11:33 -0400, Matthias Pfefferle ***@***.***>, wrote: @miklb feel free to take over the plugin. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[pfefferle]

Why not taking over this plugin? You have admin rights and you can release new versions by simply tagging a current state. Or what is the reason to give a thumb down on my comment?

[miklb]

I’m leaving the IndieWeb WP GH group. I don’t want to be part of the GitHub org.

[JOduMonT]

so
I am working on a different solution, that should solve the problem in the future: https://github.com/indieweb/wordpress-mf2-feed
mf2-feed will take over ?

[miklb]

I haven't been able to revisit my fork lately https://github.com/miklb/wordpress-uf2 but if you can open the issue there I will compare against the changes I've made there.

[JOduMonT]

@miklb sorry I don't understand; we are discussing under an open issue ?
and if you talk about opening an issue under your fork, you don't permit it.

[miklb]

No. I believe this repo has been deprecated but I am still working on a fork & have some changes in it already. If you want to follow up there I can take a look in a day or two.

[JOduMonT]

@miklb thank to following with me and trying to help me, but I'm sorry; I think I miss understood you where I should follow, because on your repo the issues features is not activated.

• as you probably could tell I'm not a wordpress dev
  but I compare SemPress and understrap (my theme) than this is the big difference I could tell might make the escaping

SemPress theme use : printf

<h1 class="page-title"><?php printf( __( 'Author Archives: %s', 'sempress' ), '<a class="url u-url fn p-fn n p-name" href="' . get_author_posts_url( get_the_author_meta( 'ID' ) ) . '" title="' . esc_attr( get_the_author() ) . '" rel="me author" itemprop="url"><span itemprop="name">' . get_the_author() . '</span></a>' ); ?></h1>

while understrap theme use : php esc_html_e

<h1><?php esc_html_e( 'About:', 'understrap' ); ?><?php echo esc_html( $curauth->nickname ); ?></h1>

BTW if you have test you want I do; I'm willing to learn and do

[JOduMonT]

FYI: this issue also appear with the Independent Publisher theme if you enable Multi-Author Mode Option and with the GeneratePress theme too