-
Notifications
You must be signed in to change notification settings - Fork 41
[*] Refactor rendergraph #533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
IAmNotHanni
wants to merge
2
commits into
main
Choose a base branch
from
hanni/rendergraph2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dad7478
to
37a0506
Compare
6afd9a1
to
c47f810
Compare
d36f172
to
7ba29ee
Compare
eda59f2
to
20f9b6f
Compare
I added dynamic rendering and this seems to have fixed the Hazard |
342548b
to
8b87f66
Compare
9e1ccaf
to
0580be9
Compare
IceflowRE
reviewed
Mar 12, 2025
This was referenced Apr 28, 2025
This was referenced May 21, 2025
2398b38
to
8fdcc33
Compare
5 tasks
c9aea2f
to
7ac48d6
Compare
7ac48d6
to
bbb3bb6
Compare
3ef796b
to
5eb039b
Compare
5eb039b
to
aeeaad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cat:refactor
refactor/clean up/simplifications/etc.
feat:rendering
rendering
prio:critical
this issue cannot be moved to a later milestone, also this label cannot be removed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this gets merged, we should release
v0.1.0-alpha.4
Major Changes
VK_API_VERSION_1_3
for Vulkan Memory Allocatormsaa_target.hpp
make_info.cpp
VkPipelineLayout
VkGraphicsPipeline
VkSampler
Minor Changes
.reset()
explicitely before smart pointer reassignment (this is redundant)Outlook (rendergraph3)
VkWriteDescriptorSet
updating mechanismVkRenderingAttachmentInfo
instead of doing it per-framecmd_buf.bind_descriptor_set
wrapper functionGraphicsPipelineBuilder
andGraphicsPass
)