Feature/greenhouse fix by iruzevic · Pull Request #256 · infinum/eightshift-forms

iruzevic · 2022-09-02T06:59:53Z

Description

Added

custom form params are now in one place and used as a enum for PHP and JS.
server errors will no longer produce fatal error on the form but will output the msg to the user, and the msg is also translatable.
option to remove all unnecessary custom params that are set on the form before the final integration post so we don't send unnecessary stuff.
new admin setting sidebar title for grouping the sections
new troubleshooting section that contains debugging options: skip validation, form reset on submit, output log.
new fallback email fields for all integrations, this will send an email with all details if there is and issue with integration.

Changed

all JS global variables for frontend and backend are now using the same name.
internal custom field for actions is now called es-form-action.
filter for setting http request from httpRequestArgs to httpRequestTimeout because it is used only to set timeout.
Greenhouse integration from wp_remote_post to regular Curl because of the issues while sending the attachments. You are now no longer limited on the amount of memory on your server to send files.
Form will now throw and error if form ID or type is missing in the request.
all remote requests now output via helper for easier and more predictable output.

Fixed

all text domains that were wrong changed from eightshift-form to eightshift-forms.
Active campaign body was set wrong and was not working.
Active campaign setting info copy for setting api key and url.
customSuccess label is now translatable from settings.
validator will now skip input type hidden because there is no need for that.

Removed

ES_DEVELOP_MODE_SKIP_VALIDATION because it is used from admin now.
ES_LOG_MODE because it is used from admin now.

Screenshots

* develop: Feature/active campaign (#248) # Conflicts: # src/Labels/Labels.php

iobrado

Nice job! Found few typos and added suggestions to fix them 🙂

src/Enqueue/Blocks/EnqueueBlocks.php

src/Integrations/Hubspot/HubspotClient.php

src/Integrations/Mailchimp/MailchimpClient.php

src/Integrations/Mailerlite/MailerliteClient.php

src/Mailer/Mailer.php

src/Rest/Routes/FormSettingsSubmitRoute.php

src/Rest/Routes/FormSubmitCustomRoute.php

goranalkovic-infinum

Left minor comments, awesome work!

src/Blocks/components/form/assets-admin/index.js

src/Hooks/FiltersGeneral.md

src/Integrations/ActiveCampaign/SettingsActiveCampaign.php

src/Rest/Routes/CacheDeleteRoute.php

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Igor Obradović <igor.obradovic@infinum.com>

dingo-d

Left some comments.

src/Hooks/FiltersTracking.md

src/Integrations/Greenhouse/GreenhouseClient.php

volfkarlo

A few micro comments.
👏

src/Blocks/components/form/assets/form.js

src/Integrations/Goodbits/GoodbitsClient.php

src/Integrations/Hubspot/HubspotClient.php

…se-fix * feature/troubleshooting-features: adding separators to sidebar menu conveting ali api responses to usage of helper adding fallback email for integrations # Conflicts: # src/Enqueue/Blocks/EnqueueBlocks.php

Co-authored-by: Karlo Volf <46056662+volfkarlo@users.noreply.github.com>

src/AdminMenus/FormGlobalSettingsAdminSubMenu.php

dingo-d

Left several comments on improvements. Some parts I've omitted adding a comment if the same thing is happening in multiple places.

src/AdminMenus/FormSettingsAdminSubMenu.php

src/Blocks/components/admin-settings/partials/sidebar-section.php

src/Enqueue/Blocks/EnqueueBlocks.php

src/Geolocation/Geolocation.php

src/Integrations/Goodbits/SettingsGoodbits.php

dingo-d · 2022-09-05T15:26:09Z

src/Rest/Routes/FormSubmitMailchimpRoute.php

+	 *
+	 * @var MailerInterface
+	 */
+	public $mailer;


Why is this public?

src/Rest/Routes/FormSubmitActiveCampaignRoute.php

Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>

volfkarlo

Micro comment, no need to correct 😄

👏

volfkarlo · 2022-09-05T15:40:25Z

src/Blocks/components/admin-settings/partials/sidebar-section.php

+			<?php foreach ($innerItems as $item) { ?>
+				<?php


No need for closing and opening PHP tags 🙂

* develop: Feature/greenhouse fix (#256) # Conflicts: # src/Geolocation/Geolocation.php

iruzevic added 4 commits August 31, 2022 10:28

adding greenhouse fix

8e157a4

Merge branch 'develop' into feature/greenhouse-fix

ee5a5c7

* develop: Feature/active campaign (#248) # Conflicts: # src/Labels/Labels.php

adding fixes for forms integrations and fields

7b3f7f5

conveting greenhouse to curl

058a3e6

iruzevic added bug Something isn't working improvement Small improvement fixes, either readability or performance improvements integrations Issues with integrations labels Sep 2, 2022

iruzevic requested a review from a team September 2, 2022 06:59

iruzevic self-assigned this Sep 2, 2022

iobrado requested changes Sep 2, 2022

View reviewed changes

goranalkovic-infinum requested changes Sep 2, 2022

View reviewed changes

Apply suggestions from code review

83cc067

Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Igor Obradović <igor.obradovic@infinum.com>

iruzevic requested review from goranalkovic-infinum and iobrado September 2, 2022 08:52

This was linked to issues Sep 2, 2022

Simplify the code #255

Closed

Issue with JS loading and localized scripts #250

Closed

iobrado approved these changes Sep 2, 2022

View reviewed changes

goranalkovic-infinum approved these changes Sep 2, 2022

View reviewed changes

dingo-d suggested changes Sep 2, 2022

View reviewed changes

volfkarlo suggested changes Sep 2, 2022

View reviewed changes

src/Blocks/components/form/assets/form.js Show resolved Hide resolved

src/Integrations/Goodbits/GoodbitsClient.php Outdated Show resolved Hide resolved

src/Integrations/Hubspot/HubspotClient.php Outdated Show resolved Hide resolved

iruzevic and others added 5 commits September 2, 2022 15:22

adding fallback email for integrations

fe3f760

conveting ali api responses to usage of helper

96ffa4d

adding separators to sidebar menu

7fd744b

Update src/Integrations/Goodbits/GoodbitsClient.php

9f05879

Co-authored-by: Karlo Volf <46056662+volfkarlo@users.noreply.github.com>

iruzevic requested review from dingo-d, goranalkovic-infinum, iobrado and volfkarlo September 5, 2022 14:35

mbmjertan approved these changes Sep 5, 2022

View reviewed changes

dingo-d reviewed Sep 5, 2022

View reviewed changes

src/AdminMenus/FormGlobalSettingsAdminSubMenu.php Outdated Show resolved Hide resolved

dingo-d suggested changes Sep 5, 2022

View reviewed changes

iruzevic and others added 3 commits September 6, 2022 08:37

Update src/AdminMenus/FormGlobalSettingsAdminSubMenu.php

96666c3

Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>

pr fixes

1b3d417

Apply suggestions from code review

194fdfd

Co-authored-by: Denis Žoljom <dingo-d@users.noreply.github.com>

iruzevic requested a review from dingo-d September 6, 2022 07:21

dingo-d approved these changes Sep 6, 2022

View reviewed changes

volfkarlo approved these changes Sep 6, 2022

View reviewed changes

updating frontend-libs

7496d97

goranalkovic-infinum approved these changes Sep 6, 2022

View reviewed changes

iruzevic merged commit 1076cfb into develop Sep 7, 2022

iruzevic deleted the feature/greenhouse-fix branch September 7, 2022 06:37

iruzevic added a commit that referenced this pull request Sep 7, 2022

Merge branch 'develop' into feature/geolocation

47abf37

* develop: Feature/greenhouse fix (#256) # Conflicts: # src/Geolocation/Geolocation.php

Conversation

iruzevic commented Sep 2, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Added

Changed

Fixed

Removed

Screenshots

Uh oh!

iobrado left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

goranalkovic-infinum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dingo-d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

volfkarlo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dingo-d left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dingo-d Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

volfkarlo left a comment

Choose a reason for hiding this comment

Uh oh!

volfkarlo Sep 5, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

iruzevic commented Sep 2, 2022 •

edited

Loading