refactor(lint): fixing using lint

sreyasppradeep1455 · sreyasppradeep1455 · commit 28028287cd2e · 2026-02-27T12:34:11.000+05:30
diff --git a/cmd/cli/cmd/deploy.go b/cmd/cli/cmd/deploy.go
@@ -6,6 +6,7 @@ package cmd
 import (
 	"faas-engine-go/internal/buildcontext"
 	"fmt"
+	"log"
 	"log/slog"
 	"path/filepath"
 
@@ -50,6 +51,10 @@ func init() {
 	deployCmd.Flags().StringVar(&filePath, "file", "", "Path to the function code directory")
 	deployCmd.Flags().StringVar(&functionName, "function-name", "", "Name of the function to deploy")
 
-	deployCmd.MarkFlagRequired("file")
-	deployCmd.MarkFlagRequired("function-name")
+	if err := deployCmd.MarkFlagRequired("file"); err != nil {
+		log.Fatalf("failed to mark flag as required: %v", err)
+	}
+	if err := deployCmd.MarkFlagRequired("function-name"); err != nil {
+		log.Fatalf("failed to mark flag as required: %v", err)
+	}
 }
diff --git a/cmd/cli/cmd/invoke.go b/cmd/cli/cmd/invoke.go
@@ -6,6 +6,7 @@ package cmd
 import (
 	"fmt"
 	"io"
+	"log"
 	"net/http"
 	"strings"
 	"time"
@@ -73,6 +74,11 @@ func init() {
 	invokeCmd.Flags().StringVar(&functionName, "name", "", "Name of the function to invoke")
 	invokeCmd.Flags().StringVar(&data, "data", "", "Data to pass to the function as input")
 
-	invokeCmd.MarkFlagRequired("name")
-	invokeCmd.MarkFlagRequired("data")
+	if err := invokeCmd.MarkFlagRequired("name"); err != nil {
+		log.Fatalf("failed to mark 'name' flag as required: %v", err)
+	}
+
+	if err := invokeCmd.MarkFlagRequired("data"); err != nil {
+		log.Fatalf("failed to mark 'data' flag as required: %v", err)
+	}
 }
diff --git a/cmd/cli/cmd/root.go b/cmd/cli/cmd/root.go
@@ -4,6 +4,7 @@ Copyright © 2026 NAME HERE <EMAIL ADDRESS>
 package cmd
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/spf13/cobra"
@@ -31,6 +32,7 @@ var rootCmd = &cobra.Command{
 func Execute() {
 	err := rootCmd.Execute()
 	if err != nil {
+		fmt.Fprintln(os.Stderr, err)
 		os.Exit(1)
 	}
 }
diff --git a/cmd/runtime-manager/main.go b/cmd/runtime-manager/main.go
@@ -6,6 +6,7 @@ import (
 	"faas-engine-go/internal/sdk"
 	"faas-engine-go/internal/service"
 	"fmt"
+	"log"
 	"net/http"
 
 	"github.com/gorilla/mux"
@@ -32,9 +33,10 @@ func main() {
 	r.HandleFunc("/functions", api.GetFunctionsHandler).Methods("GET")
 	r.HandleFunc("/functions/{functionName}", api.DeleteFunctionHandler).Methods("DELETE")
 
-	http.ListenAndServe(":8080", r)
+	if err = http.ListenAndServe(":8080", r); err != nil {
+		log.Fatalf("server failed: %v", err)
+	}
 }
-
 func HomeHandler(w http.ResponseWriter, r *http.Request) {
 	fmt.Fprintf(w, "Welcome to the Runtime Manager!")
 }
diff --git a/internal/api/delete.go b/internal/api/delete.go
@@ -16,5 +16,7 @@ func DeleteFunctionHandler(w http.ResponseWriter, r *http.Request) {
 
 	w.Header().Set("Content-type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	json.NewEncoder(w).Encode(response)
+	if err := json.NewEncoder(w).Encode(response); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
diff --git a/internal/api/deploy.go b/internal/api/deploy.go
@@ -60,5 +60,7 @@ func DeployHandler(deployer Deployer) http.HandlerFunc {
 func writeJSON(w http.ResponseWriter, status int, payload any) {
 	w.Header().Set("Content-Type", "application/json")
 	w.WriteHeader(status)
-	json.NewEncoder(w).Encode(payload)
+	if err := json.NewEncoder(w).Encode(payload); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
diff --git a/internal/api/get.go b/internal/api/get.go
@@ -16,5 +16,7 @@ func GetFunctionsHandler(w http.ResponseWriter, r *http.Request) {
 
 	w.Header().Set("Content-type", "application/json")
 	w.WriteHeader(http.StatusOK)
-	json.NewEncoder(w).Encode(response)
+	if err := json.NewEncoder(w).Encode(response); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
diff --git a/internal/api/health.go b/internal/api/health.go
@@ -21,14 +21,18 @@ func GreetHandler(w http.ResponseWriter, r *http.Request) {
 	if name == "" {
 
 		w.WriteHeader(http.StatusBadRequest)
-		json.NewEncoder(w).Encode(response{
+		if err := json.NewEncoder(w).Encode(response{
 			Message: "Missing 'name' query parameter",
-		})
+		}); err != nil {
+			http.Error(w, err.Error(), http.StatusInternalServerError)
+		}
 		return
 	}
 
 	w.WriteHeader(http.StatusOK)
-	json.NewEncoder(w).Encode(response{
+	if err := json.NewEncoder(w).Encode(response{
 		Message: fmt.Sprintf("Hello, %s!", name),
-	})
+	}); err != nil {
+		http.Error(w, err.Error(), http.StatusInternalServerError)
+	}
 }
diff --git a/internal/api/invoke.go b/internal/api/invoke.go
@@ -38,6 +38,8 @@ func InvokeHandler(invoker Invoker) http.HandlerFunc {
 
 		w.Header().Set("Content-Type", "application/json")
 		w.WriteHeader(http.StatusOK)
-		json.NewEncoder(w).Encode(result)
+		if err := json.NewEncoder(w).Encode(result); err != nil {
+			http.Error(w, err.Error(), http.StatusInternalServerError)
+		}
 	}
 }
diff --git a/internal/sdk/image.go b/internal/sdk/image.go
@@ -19,7 +19,9 @@ func PullImage(ctx context.Context, apiclient *client.Client, imageName string)
 
 	defer imageRef.Close()
 	slog.Info("Pulling image....")
-	io.Copy(io.Discard, imageRef)
+	if _, err := io.Copy(io.Discard, imageRef); err != nil {
+		return fmt.Errorf("failed to copy image data: %w", err)
+	}
 	return nil
 }
 
@@ -110,7 +112,9 @@ func PushImage(ctx context.Context, apiclient *client.Client, target string) err
 		return fmt.Errorf("failed to push image: %w", err)
 	}
 	defer imagePush.Close()
-	io.Copy(io.Discard, imagePush)
+	if _, err := io.Copy(io.Discard, imagePush); err != nil {
+		return fmt.Errorf("failed to read push output: %w", err)
+	}
 	return nil
 }
 
diff --git a/internal/service/invoke_service.go b/internal/service/invoke_service.go
@@ -46,7 +46,9 @@ func (f *FunctionInvoker) Invoke(ctx context.Context, functionName string, paylo
 	}
 
 	port, err := network.ParsePort("8080/tcp")
-
+	if err != nil {
+		return nil, fmt.Errorf("failed to parse port: %w", err)
+	}
 	var hostPort string
 
 	deadline := time.Now().Add(10 * time.Second)
diff --git a/internal/test/api/deploy_test.go b/internal/test/api/deploy_test.go
@@ -34,9 +34,13 @@ func TestDeployHandler_InvalidSize(t *testing.T) {
 	}
 
 	large := make([]byte, 51<<20)
-	part.Write(large)
+	if _, err := part.Write(large); err != nil {
+		t.Fatal(err)
+	}
 
-	writer.WriteField("name", "test-fn")
+	if err := writer.WriteField("name", "test-fn"); err != nil {
+		t.Fatalf("failed to write name field: %v", err)
+	}
 	writer.Close()
 
 	req := httptest.NewRequest(http.MethodPost, "/functions", body)
@@ -62,9 +66,14 @@ func TestDeployHandler_Success(t *testing.T) {
 	}
 
 	data := make([]byte, 1<<20)
-	part.Write(data)
+	if _, err := part.Write(data); err != nil {
+		t.Fatalf("failed to write file part: %v", err)
+	}
+
+	if err := writer.WriteField("name", "test-fn"); err != nil {
+		t.Fatalf("failed to write field: %v", err)
+	}
 
-	writer.WriteField("name", "test-fn")
 	writer.Close()
 
 	req := httptest.NewRequest(http.MethodPost, "/functions", body)
@@ -91,7 +100,10 @@ func TestDeployHandler_MissingFile(t *testing.T) {
 	body := &bytes.Buffer{}
 	writer := multipart.NewWriter(body)
 
-	writer.WriteField("name", "test-fn")
+	if err := writer.WriteField("name", "test-fn"); err != nil {
+		t.Fatalf("failed to write field: %v", err)
+	}
+
 	writer.Close()
 
 	req := httptest.NewRequest(http.MethodPost, "/functions", body)
@@ -116,9 +128,13 @@ func TestDeployHandler_InternalError(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	part.Write([]byte("valid small content"))
+	if _, err := part.Write([]byte("valid small content")); err != nil {
+		t.Fatalf("failed to write payload: %v", err)
+	}
 
-	writer.WriteField("name", "test-fn")
+	if err := writer.WriteField("name", "test-fn"); err != nil {
+		t.Fatalf("failed to write field: %v", err)
+	}
 	writer.Close()
 
 	req := httptest.NewRequest(http.MethodPost, "/functions", body)
diff --git a/internal/test/buildcontext/packager_test.go b/internal/test/buildcontext/packager_test.go
@@ -202,7 +202,9 @@ func TestSendTarStream_Success(t *testing.T) {
 		}
 
 		w.WriteHeader(http.StatusOK)
-		json.NewEncoder(w).Encode(mockResponse)
+		if err := json.NewEncoder(w).Encode(mockResponse); err != nil {
+			t.Fatalf("Failed to encode response: %v", err)
+		}
 	}))
 	defer server.Close()
 

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,7 @@ Copyright © 2026 NAME HERE <EMAIL ADDRESS>`
`4`	`4`	`package cmd`
`5`	`5`
`6`	`6`	`import (`
	`7`	`+ "fmt"`
`7`	`8`	`"os"`
`8`	`9`
`9`	`10`	`"github.com/spf13/cobra"`
`@@ -31,6 +32,7 @@ var rootCmd = &cobra.Command{`
`31`	`32`	`func Execute() {`
`32`	`33`	`err := rootCmd.Execute()`
`33`	`34`	`if err != nil {`
	`35`	`+ fmt.Fprintln(os.Stderr, err)`
`34`	`36`	`os.Exit(1)`
`35`	`37`	`}`
`36`	`38`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,7 @@ func DeleteFunctionHandler(w http.ResponseWriter, r *http.Request) {`
`16`	`16`
`17`	`17`	`w.Header().Set("Content-type", "application/json")`
`18`	`18`	`w.WriteHeader(http.StatusOK)`
`19`		`- json.NewEncoder(w).Encode(response)`
	`19`	`+ if err := json.NewEncoder(w).Encode(response); err != nil {`
	`20`	`+ http.Error(w, err.Error(), http.StatusInternalServerError)`
	`21`	`+ }`
`20`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -60,5 +60,7 @@ func DeployHandler(deployer Deployer) http.HandlerFunc {`
`60`	`60`	`func writeJSON(w http.ResponseWriter, status int, payload any) {`
`61`	`61`	`w.Header().Set("Content-Type", "application/json")`
`62`	`62`	`w.WriteHeader(status)`
`63`		`- json.NewEncoder(w).Encode(payload)`
	`63`	`+ if err := json.NewEncoder(w).Encode(payload); err != nil {`
	`64`	`+ http.Error(w, err.Error(), http.StatusInternalServerError)`
	`65`	`+ }`
`64`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -16,5 +16,7 @@ func GetFunctionsHandler(w http.ResponseWriter, r *http.Request) {`
`16`	`16`
`17`	`17`	`w.Header().Set("Content-type", "application/json")`
`18`	`18`	`w.WriteHeader(http.StatusOK)`
`19`		`- json.NewEncoder(w).Encode(response)`
	`19`	`+ if err := json.NewEncoder(w).Encode(response); err != nil {`
	`20`	`+ http.Error(w, err.Error(), http.StatusInternalServerError)`
	`21`	`+ }`
`20`	`22`	`}`
Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,8 @@ func InvokeHandler(invoker Invoker) http.HandlerFunc {`
`38`	`38`
`39`	`39`	`w.Header().Set("Content-Type", "application/json")`
`40`	`40`	`w.WriteHeader(http.StatusOK)`
`41`		`- json.NewEncoder(w).Encode(result)`
	`41`	`+ if err := json.NewEncoder(w).Encode(result); err != nil {`
	`42`	`+ http.Error(w, err.Error(), http.StatusInternalServerError)`
	`43`	`+ }`
`42`	`44`	`}`
`43`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,9 @@ func PullImage(ctx context.Context, apiclient *client.Client, imageName string)`
`19`	`19`
`20`	`20`	`defer imageRef.Close()`
`21`	`21`	`slog.Info("Pulling image....")`
`22`		`- io.Copy(io.Discard, imageRef)`
	`22`	`+ if _, err := io.Copy(io.Discard, imageRef); err != nil {`
	`23`	`+ return fmt.Errorf("failed to copy image data: %w", err)`
	`24`	`+ }`
`23`	`25`	`return nil`
`24`	`26`	`}`
`25`	`27`
`@@ -110,7 +112,9 @@ func PushImage(ctx context.Context, apiclient *client.Client, target string) err`
`110`	`112`	`return fmt.Errorf("failed to push image: %w", err)`
`111`	`113`	`}`
`112`	`114`	`defer imagePush.Close()`
`113`		`- io.Copy(io.Discard, imagePush)`
	`115`	`+ if _, err := io.Copy(io.Discard, imagePush); err != nil {`
	`116`	`+ return fmt.Errorf("failed to read push output: %w", err)`
	`117`	`+ }`
`114`	`118`	`return nil`
`115`	`119`	`}`
`116`	`120`