fix: use actual host in deployment links and fix parallel build test conflicts

Deploy changes:
- Replace hardcoded "localhost" with request host in deployment messages
- Use nip.io domain for non-localhost hosts (e.g., 192.168.1.100.nip.io)
- Keep .localhost for localhost/127.0.0.1 deployments

Test changes:
- Serialize build tests to avoid containerd lease conflicts
- Fix TestBuildImage_duplicateImageName to use custom image name
- Add error handling for concurrent ImagePrune operations

Author: sreyasppradeep1455

internal/api/deploy.go

@@ -10,6 +10,7 @@ import (
 	"fmt"
 	"io"
 	"log/slog"
+	"net"
 	"net/http"
 	"strings"
 	"time"
@@ -124,14 +125,26 @@ func DeployHandler(deployer Deployer, fs FunctionStore) http.HandlerFunc {
 			slog.Error("failed to deactivate old versions", "error", err)
 		}
 
+		host, _, err := net.SplitHostPort(r.Host)
+		if err != nil {
+			host = r.Host
+		}
+
+		var endpoint string
+		if host == "localhost" || host == "127.0.0.1" {
+			endpoint = fmt.Sprintf("%s.localhost", functionName)
+		} else {
+			endpoint = fmt.Sprintf("%s.%s.nip.io", functionName, host)
+		}
+
 		fn := &models.Function{
 			Name:            functionName,
 			Version:         functionVersion,
 			PackageChecksum: checksum,
 			Image:           config.ImageRef(config.FunctionsRepo, functionName, functionVersion),
 			Runtime:         "node",
 			ScheduleCron:    "",
-			Endpoint:        fmt.Sprintf("%s.localhost", functionName),
+			Endpoint:        endpoint,
 			Status:          "active",
 			CreatedAt:       time.Now(),
 		}
@@ -142,7 +155,7 @@ func DeployHandler(deployer Deployer, fs FunctionStore) http.HandlerFunc {
 			fmt.Fprintf(out, "\nWARNING: function deployed but DB insert failed\n")
 		}
 
-		_, _ = fmt.Fprintf(out, "\nYour function is live at: http://%s.localhost\n\n", nameParam)
+		_, _ = fmt.Fprintf(out, "\nYour function is live at: http://%s\n\n", endpoint)
 		w.Header().Set("X-Deploy-Status", "OK")
 	}
 }

internal/sdk/image.go

@@ -79,7 +79,9 @@ func (d *DockerClient) BuildImage(
 
 	_, err = d.cli.ImagePrune(ctx, client.ImagePruneOptions{})
 	if err != nil {
-		return err
+		if !strings.Contains(err.Error(), "prune operation is already running") {
+			return err
+		}
 	}
 
 	return nil

internal/sdk/image_test.go

@@ -104,7 +104,6 @@ func TestPullImage_InvalidImage(t *testing.T) {
 }
 
 func TestBuildImage_Success(t *testing.T) {
-	t.Parallel()
 
 	// data, err := os.ReadFile("test_samples/function.tar")
 	tarstream, err := buildcontext.CreateTarStream("../../samples/hello", "node")
@@ -119,7 +118,6 @@ func TestBuildImage_Success(t *testing.T) {
 }
 
 func TestBuildImage_InvalidDirectory(t *testing.T) {
-	t.Parallel()
 
 	tarstream, err := buildcontext.CreateTarStream("../test_samples/invalid", "node")
 	if err == nil {
@@ -133,32 +131,41 @@ func TestBuildImage_InvalidDirectory(t *testing.T) {
 }
 
 func TestBuildImage_duplicateImageName(t *testing.T) {
-	t.Parallel()
+	testImageName := "test-duplicate-rebuild"
 
-	err := testDocker.PullImage(testCtx, "alpine")
+	// Create first build
+	tarstream1, err := buildcontext.CreateTarStream("../../samples/hello", "node")
 	if err != nil {
-		t.Fatalf("unexpected error pulling alpine image: %v", err)
+		t.Skipf("unexpected error - failed to create Tar stream: %v", err)
 	}
-	t.Log("Pulled image successfully")
+
+	err = testDocker.BuildImage(testCtx, testImageName, tarstream1, io.Discard)
+	if err != nil {
+		t.Fatalf("unexpected error on first build: %v", err)
+	}
+	t.Log("First build succeeded")
 
 	defer func() {
-		err := testDocker.RemoveImage(testCtx, "alpine:latest")
+		err := testDocker.RemoveImage(testCtx, testImageName+":latest")
 		if err != nil {
 			t.Logf("failed to remove image: %v", err)
 		}
 	}()
 
-	tarstream, err := buildcontext.CreateTarStream("../../samples/hello", "node")
+	// Create second build with same image name (rebuild/redeployment scenario)
+	tarstream2, err := buildcontext.CreateTarStream("../../samples/hello", "node")
 	if err != nil {
 		t.Skipf("unexpected error - failed to create Tar stream: %v", err)
 	}
 
-	err = testDocker.BuildImage(testCtx, "alpine", tarstream, io.Discard)
-	if err == nil {
-		t.Fatal("expected error for duplicate image name, got nil")
+	// BuildImage now allows rebuilding existing images with ForceRemove: true
+	// This test verifies that rebuilding an existing image succeeds (for redeployment)
+	err = testDocker.BuildImage(testCtx, testImageName, tarstream2, io.Discard)
+	if err != nil {
+		t.Fatalf("expected build to succeed for duplicate image name (rebuild), got error: %v", err)
 	}
 
-	t.Logf("received expected error: %v", err)
+	t.Log("successfully rebuilt existing image")
 }
 
 func TestTagImage_Success(t *testing.T) {