fix(image): fix flaky image rebuild test

Author: sreyasppradeep1455

internal/api/deploy_test.go

@@ -87,6 +87,7 @@ func TestDeployHandler_Success(t *testing.T) {
 
 	req := httptest.NewRequest(http.MethodPost, "/functions", body)
 	req.Header.Set("Content-Type", writer.FormDataContentType())
+	req.Host = "localhost"
 
 	rr := httptest.NewRecorder()
 

internal/sdk/image_test.go

@@ -104,6 +104,7 @@ func TestPullImage_InvalidImage(t *testing.T) {
 }
 
 func TestBuildImage_Success(t *testing.T) {
+	t.Parallel()
 
 	// data, err := os.ReadFile("test_samples/function.tar")
 	tarstream, err := buildcontext.CreateTarStream("../../samples/hello", "node")
@@ -118,6 +119,7 @@ func TestBuildImage_Success(t *testing.T) {
 }
 
 func TestBuildImage_InvalidDirectory(t *testing.T) {
+	t.Parallel()
 
 	tarstream, err := buildcontext.CreateTarStream("../test_samples/invalid", "node")
 	if err == nil {
@@ -131,41 +133,42 @@ func TestBuildImage_InvalidDirectory(t *testing.T) {
 }
 
 func TestBuildImage_duplicateImageName(t *testing.T) {
-	testImageName := "test-duplicate-rebuild"
+	t.Parallel()
+
+	imageName := "test-rebuild-image:latest"
+
+	defer func() {
+		err := testDocker.RemoveImage(testCtx, imageName)
+		if err != nil {
+			t.Logf("failed to remove image: %v", err)
+		}
+	}()
 
-	// Create first build
 	tarstream1, err := buildcontext.CreateTarStream("../../samples/hello", "node")
 	if err != nil {
 		t.Skipf("unexpected error - failed to create Tar stream: %v", err)
 	}
 
-	err = testDocker.BuildImage(testCtx, testImageName, tarstream1, io.Discard)
+	// First build
+	err = testDocker.BuildImage(testCtx, imageName, tarstream1, io.Discard)
 	if err != nil {
-		t.Fatalf("unexpected error on first build: %v", err)
+		t.Fatalf("expected first build to succeed, got error: %v", err)
 	}
-	t.Log("First build succeeded")
-
-	defer func() {
-		err := testDocker.RemoveImage(testCtx, testImageName+":latest")
-		if err != nil {
-			t.Logf("failed to remove image: %v", err)
-		}
-	}()
+	t.Log("first build succeeded")
 
-	// Create second build with same image name (rebuild/redeployment scenario)
+	// Second build with same image name - simulates redeployment
+	// BuildImage with ForceRemove: true should handle this gracefully
 	tarstream2, err := buildcontext.CreateTarStream("../../samples/hello", "node")
 	if err != nil {
 		t.Skipf("unexpected error - failed to create Tar stream: %v", err)
 	}
 
-	// BuildImage now allows rebuilding existing images with ForceRemove: true
-	// This test verifies that rebuilding an existing image succeeds (for redeployment)
-	err = testDocker.BuildImage(testCtx, testImageName, tarstream2, io.Discard)
+	err = testDocker.BuildImage(testCtx, imageName, tarstream2, io.Discard)
 	if err != nil {
-		t.Fatalf("expected build to succeed for duplicate image name (rebuild), got error: %v", err)
+		t.Fatalf("expected rebuild with same image name to succeed, got error: %v", err)
 	}
 
-	t.Log("successfully rebuilt existing image")
+	t.Log("successfully rebuilt image with same name")
 }
 
 func TestTagImage_Success(t *testing.T) {