feature/deploy#39
Open
sreyasppradeep1455 wants to merge 3 commits intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Correct deploy endpoint with proper host preservation through proxy
Problem
When deploying functions, the CLI displayed an incorrect deployment URL that always showed
localhostregardless of the actual server IP address. This happened because requests going through the proxy lost the original client host information.Root Cause
localhost:8080(runtime-manager)localhost)Solution
X-Forwarded-Hostheader to preserve the original client host when forwarding requests to the runtime-managerX-Forwarded-Hostheader first (set by proxy)r.Hostif no proxy headerlocalhostfor local dev,{ip}.nip.iofor remote addressesChanges
internal/proxy/proxy.go: Added X-Forwarded-Host header for control plane requestsinternal/api/deploy.go: Updated host detection and endpoint formatting logicinternal/service/deploy_service.go: Service layer updatesTesting
Deploy a function and verify the output URL now shows:
http://functionname.localhosthttp://functionname.{ip}.nip.iohttp://calc.10.30.20.196.nip.ioFixes