refactor(modules/route-53-record): code cleanup and simplify names

Author: saumitra-dev

modules/route-53-record/main.tf

@@ -1,20 +1,20 @@
 locals {
   domain_parts = regexall("(.*\\.)?(.*\\..*)", var.domain)
-  base_domain  = length(local.domain_parts) > 0 && length(local.domain_parts[0]) > 1 ? local.domain_parts[0][1] : var.domain
+  base_domain = (
+    length(local.domain_parts) > 0 && length(local.domain_parts[0]) > 1 ?
+  local.domain_parts[0][1] : var.domain)
 }
 
-data "aws_acm_certificate" "domain" {
-  domain      = local.base_domain
-  statuses    = ["ISSUED"]
-  most_recent = false
-}
+################################################################################
+# ACM Certificate
+################################################################################
 
-data "aws_route53_zone" "zone" {
+data "aws_route53_zone" "base_domain" {
   name = local.base_domain
 }
 
-resource "aws_route53_record" "record" {
-  zone_id = data.aws_route53_zone.zone.zone_id
+resource "aws_route53_record" "this" {
+  zone_id = data.aws_route53_zone.base_domain.zone_id
   name    = var.domain
   type    = "A"
 

modules/route-53-record/outputs.tf

@@ -1,9 +1,13 @@
-output "certificate_arn" {
-  description = "ARN of the base domain certificate"
-  value       = data.aws_acm_certificate.domain.arn
+################################################################################
+# Route53 Record
+################################################################################
+
+output "id" {
+  description = "Identifier of the Route53 Record"
+  value       = aws_route53_record.this.id
 }
 
 output "zone_id" {
   description = "ID of the Route 53 zone"
-  value       = data.aws_route53_zone.zone.zone_id
+  value       = data.aws_route53_zone.base_domain.zone_id
 }

modules/route-53-record/variables.tf

@@ -1,14 +1,21 @@
+################################################################################
+# Route53 Record
+################################################################################
+
 variable "domain" {
-  description = "Domain name"
+  description = "(Required) Domain name for which the certificate should be issued."
   type        = string
+  nullable    = false
 }
 
 variable "alb_dns_name" {
-  description = "ALB DNS name"
+  description = "(Required) DNS domain name for a CloudFront distribution, S3 bucket, ELB, or another resource record set in this hosted zone."
   type        = string
+  nullable    = false
 }
 
 variable "alb_zone_id" {
-  description = "ALB zone ID"
+  description = "(Required) Hosted zone ID for a CloudFront distribution, S3 bucket, ELB, or Route 53 hosted zone."
   type        = string
+  nullable    = false
 }