Skip to content

refactor: use Url in the config #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 6, 2025
Merged

refactor: use Url in the config #136

merged 2 commits into from
Aug 6, 2025

Conversation

prestwich
Copy link
Member

@prestwich prestwich commented Aug 5, 2025

Use url::Url in the config where appropriate. This does not change over the additional broadcast urls, as connect accepts a &str

Copy link
Member Author

prestwich commented Aug 5, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@prestwich prestwich marked this pull request as ready for review August 5, 2025 15:20
Base automatically changed from prestwich/builder-stream to main August 5, 2025 16:39
Copy link
Member

@Evalir Evalir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prestwich prestwich enabled auto-merge (squash) August 6, 2025 13:59
@prestwich prestwich merged commit ce5af79 into main Aug 6, 2025
6 checks passed
@prestwich prestwich deleted the prestwich/url branch August 6, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants