-
Notifications
You must be signed in to change notification settings - Fork 64
feat: Add helm chart #4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add helm chart #4863
Conversation
556f126
to
438f344
Compare
This comment has been minimized.
This comment has been minimized.
438f344
to
7da9743
Compare
This comment has been minimized.
This comment has been minimized.
All in all, a very clean and nice build Helm Chart 👍 What do you think about installing For this you would have to set the insecure flag so that you don't have to generate a key and install an ingress controller and set * as host. tilt/namespace.yaml: ...
---
apiVersion: v1
kind: Namespace
metadata:
name: ingress-nginx tilt/scrumlr-values.yaml: backend:
config:
natsUrl: nats://nats.nats.svc.cluster.local:4222
secrets:
databaseUrl: postgres://postgres:SuperStrongpassword@postgres-postgresql.postgres.svc.cluster.local:5432/scrumlr?sslmode=disable
extraConfig:
# Do NOT use this config for production deployments, this flag enables hardcoded, insecure keys
SCRUMLR_INSECURE: true
ingress:
enabled: true
annotations:
# Websocket optimization https://kubernetes.github.io/ingress-nginx/user-guide/miscellaneous/#websockets
nginx.ingress.kubernetes.io/proxy-send-timeout: "7200"
nginx.ingress.kubernetes.io/proxy-read-timeout: "7200"
hostname: "*"
ingressClassName: "nginx" tilt/Tiltfile:
|
Other small things I would change/ nits:
|
afafb55
to
fc1ec6a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a Helm chart along with associated unit tests and a Tilt file for simplified Kubernetes deployment of Scrumlr.
- Introduces a complete Helm chart with templates for backend, frontend, ingress, secrets, configmaps, services, HPA, and deployments.
- Adds unit tests to validate the rendered resources from the Helm chart.
- Provides Makefile targets for rendering, linting, packaging, and deploying the Helm chart with Tilt.
Reviewed Changes
Copilot reviewed 36 out of 36 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
deployment/helm/scrumlr/tests/backend/configmap_test.yaml | Adds tests to validate the backend configmap settings. |
deployment/helm/scrumlr/templates/ingress_tls_secrets.yaml | Provides TLS secret generation for ingress using either provided or self-signed certs. |
deployment/helm/scrumlr/templates/ingress.yaml | Defines ingress rules and TLS configuration based on provided values. |
deployment/helm/scrumlr/templates/frontend/*.yaml | Contains service, secrets, HPA, deployment, and configmap for the frontend. |
deployment/helm/scrumlr/templates/backend/*.yaml | Contains service, secrets, HPA, deployment, and configmap for the backend. |
deployment/helm/scrumlr/templates/_helpers.tpl | Provides helper template functions for naming, labels, and certificate annotations. |
deployment/helm/scrumlr/README.md | Documents available parameters and usage instructions for the Helm chart. |
deployment/helm/scrumlr/Makefile | Adds Makefile tasks for rendering, linting, packaging, testing, and Tilt deployment. |
deployment/helm/scrumlr/Chart.yaml | Defines the Helm chart metadata for Scrumlr. |
deployment/helm/scrumlr/.helmignore and .gitignore | Specifies files to ignore when packaging or committing the Helm chart. |
deployment/helm/README.md | Provides an overview and development instructions for the Kubernetes deployment. |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jan Schnurpfeil <schnurpfeil.j@gmail.com>
Co-authored-by: Jan Schnurpfeil <schnurpfeil.j@gmail.com>
Co-authored-by: Jan Schnurpfeil <schnurpfeil.j@gmail.com>
Co-authored-by: Jan Schnurpfeil <schnurpfeil.j@gmail.com>
Co-authored-by: Jan Schnurpfeil <6825386+Zaunei@users.noreply.github.com>
3eba92e
to
f291bf2
Compare
The deployment to the dev cluster was successful. You can find the deployment here: https://4863.development.scrumlr.fra.ics.inovex.io Deployed Images
|
🐙 OctomindTest Report: 14/14 successful.
commit sha: 0d89d55 |
Description
Add a helm chart for easy kubernetes deployment
Changelog
Checklist