Skip to content

Conversation

Schwehn42
Copy link
Member

@Schwehn42 Schwehn42 commented Apr 3, 2025

Description

This PR finally adds the view to create and edit templates.

Changelog

Legend: A - Added, M - Modified, D - Deleted

e2e testing

made cypress TS ready and added several e2e tests for templates.

  • A cypress/.gitignore
  • D cypress/e2e/landingPageToBoard-spec.cy.ts
  • A cypress/e2e/login-spec.cy.ts
  • A cypress/e2e/templates-spec.cy.ts
  • M cypress/support/commands.ts
  • M cypress/support/index.d.ts

server

made some minor changes for the API, like removing access_policy from templates

  • M server/src/api/info.go
  • M server/src/api/router.go
  • M server/src/common/dto/board_templates.go
  • M server/src/database/board_templates.go
  • M server/src/database/board_templates_test.go
  • M server/src/database/testdata/fixture.yml
  • M server/src/initialize/migrations/sql/17_add_board_templates.up.sql
  • A server/src/initialize/migrations/sql/22_remove_template_access_policy.down.sql
  • A server/src/initialize/migrations/sql/22_remove_template_access_policy.up.sql
  • M server/src/main.go
  • M server/src/services/board_templates/board_templates.go

FE tests

  • M src/components/Avatar/tests/snapshots/Avatar.test.tsx.snap
  • M src/components/Avatar/tests/Avatar.test.tsx
  • M src/components/Column/tests/snapshots/Column.test.tsx.snap
  • A src/components/ColumnsConfigurator/AddTemplateColumn/tests/snapshots/AddTemplateColumn.test.tsx.snap
  • A src/components/ColumnsConfigurator/AddTemplateColumn/tests/AddTemplateColumn.test.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnConfiguratorColumnNameDetails/tests/ColumnConfiguratorColumnNameDetails.test.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/tests/ColumnConfiguratorColumn.test.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnConfiguratorColumnNameDetails/tests/snapshots/ColumnConfiguratorColumnNameDetails.test.tsx.snap
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/tests/snapshots/ColumnConfiguratorColumn.test.tsx.snap
  • A src/components/ColumnsConfigurator/ColumnsMiniView/tests/ColumnsMiniView.test.tsx
  • A src/components/ColumnsConfigurator/ColumnsMiniView/tests/snapshots/ColumnsMiniView.test.tsx.snap
  • M src/components/Requests/tests/snapshots/Request.test.tsx.snap
  • A src/components/ColumnsConfigurator/tests/ColumnsConfigurator.test.tsx
  • A src/components/ColumnsConfigurator/tests/snapshots/ColumnsConfigurator.test.tsx.snap
  • A src/components/Select/SelectOption/tests/SelectOption.test.tsx
  • A src/components/Select/SelectOption/tests/snapshots/SelectOption.test.tsx.snap
  • A src/components/Select/tests/Select.test.tsx
  • A src/components/Select/tests/snapshots/Select.test.tsx.snap
  • M src/components/SettingsDialog/Participants/tests/snapshots/Participants.test.tsx.snap
  • M src/components/SettingsDialog/tests/snapshots/SettingsDialog.test.tsx.snap
  • A src/routes/Boards/TemplateEditor/tests/TemplateEditor.test.tsx
  • A src/routes/Boards/TemplateEditor/tests/snapshots/TemplateEditor.test.tsx.snap
  • A src/routes/Boards/Templates/tests/Templates.test.tsx
  • A src/routes/Boards/Templates/tests/snapshots/Templates.test.tsx.snap
  • A src/routes/Boards/tests/Boards.test.tsx
  • A src/routes/Boards/tests/snapshots/Boards.test.tsx.snap
  • A src/components/Templates/TemplateCard/tests/TemplateCard.test.tsx
  • A src/components/Templates/TemplateCard/tests/snapshots/TemplateCard.test.tsx.snap

FE

Store / API
  • M src/api/board.ts
  • M src/api/index.ts
  • M src/api/info.ts
  • A src/api/templateColumns.ts
  • M src/api/templates.ts
  • M src/store/features/board/thunks.ts
  • M src/store/features/board/types.ts
  • M src/store/features/templateColumns/index.ts
  • M src/store/features/templateColumns/reducer.ts
  • M src/store/features/templateColumns/thunks.ts
  • M src/store/features/templateColumns/types.ts
  • M src/store/features/templates/reducer.ts
  • M src/store/features/templates/thunks.ts
  • M src/store/features/templates/types.ts
  • M src/store/features/view/reducer.ts
  • M src/store/features/view/types.ts
  • M src/store/store.ts
Components (Templates)
  • M src/components/Column/ColumnSettings.tsx
  • A src/components/ColumnsConfigurator/AddTemplateColumn/AddTemplateColumn.scss
  • A src/components/ColumnsConfigurator/AddTemplateColumn/AddTemplateColumn.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfigurator.scss
  • A src/components/ColumnsConfigurator/ColumnsConfigurator.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfigurator.types.ts
  • A src/components/ColumnsConfigurator/ColumnsConfigurator.utils.ts
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnConfiguratorColumnNameDetails/ColumnConfiguratorColumnNameDetails.scss
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnConfiguratorColumnNameDetails/ColumnConfiguratorColumnNameDetails.tsx
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnsConfiguratorColumn.scss
  • A src/components/ColumnsConfigurator/ColumnsConfiguratorColumn/ColumnsConfiguratorColumn.tsx
  • A src/components/ColumnsConfigurator/ColumnsMiniView/ColumnsMiniView.scss
  • A src/components/ColumnsConfigurator/ColumnsMiniView/ColumnsMiniView.tsx
  • A src/components/Templates/AccessSettings/AccessSettings.scss
  • A src/components/Templates/AccessSettings/AccessSettings.tsx
  • M src/components/Templates/CreateTemplateCard/CreateTemplateCard.tsx
  • M src/components/Templates/TemplateCard/TemplateCard.tsx
  • M src/routes/Boards/Boards.scss
  • M src/routes/Boards/Boards.tsx
  • M src/routes/Boards/Legacy/LegacyNewBoard.tsx
  • A src/routes/Boards/TemplateEditor/TemplateEditor.scss
  • A src/routes/Boards/TemplateEditor/TemplateEditor.tsx
  • M src/routes/Boards/Templates/Templates.scss
  • M src/routes/Boards/Templates/Templates.tsx
  • A src/routes/Guards/VerifiedAccountGuard.tsx
  • M src/routes/LoginBoard/LoginBoard.tsx
  • M src/routes/Router.tsx
Components (Util)
  • M src/components/Button/Button.tsx
  • M src/components/ColorPicker/ColorPicker.scss
  • M src/components/ColorPicker/ColorPicker.tsx
  • A src/components/Dropdown/Dropdown.scss
  • A src/components/Dropdown/Dropdown.tsx
  • R058 src/components/SearchBar/SearchBar.scss src/components/Input/Input.scss
  • A src/components/Input/Input.tsx
  • M src/components/MiniMenu/MiniMenu.scss
  • M src/components/MiniMenu/MiniMenu.tsx
  • D src/components/SearchBar/SearchBar.tsx
  • A src/components/Select/Select.scss
  • A src/components/Select/Select.tsx
  • A src/components/Select/SelectOption/SelectOption.scss
  • A src/components/Select/SelectOption/SelectOption.tsx
  • A src/components/TextArea/TextArea.scss
  • A src/components/TextArea/TextArea.tsx
Util
  • M src/constants/colors.ts
  • A src/constants/recommendedTemplates.json
  • M src/constants/style.scss
  • A src/constants/templates.ts
  • M src/testUtils.tsx
  • A src/utils/hooks/useInputValidation.ts
  • A src/utils/hooks/useSelect.ts
  • M src/utils/test/getTestApplicationState.ts

other

  • M .env
    new FE env var: REACT_APP_LEGACY_CREATE_BOARD allows to use old create board view
  • M k8s/deployment.yaml
  • M server/docker-compose.yml
    new BE env var: SCRUMLR_ALLOW_ANONYMOUS_CUSTOM_TEMPLATES allows for anon users to use the create template feature, which is default off
  • A src/assets/icons/add-column.svg
  • A src/assets/icons/drag-and-drop.svg
  • M src/i18n/de/translation.json
  • M src/i18n/en/translation.json

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jun 16, 2025
@Schwehn42 Schwehn42 linked an issue Jun 16, 2025 that may be closed by this pull request

This comment has been minimized.

as board templates no longer have that column
@Schwehn42 Schwehn42 removed the Review Needed This pull request is ready for review label Jun 18, 2025
Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4977.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-2a12640

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-2a12640

Copy link

octomind-dev bot commented Jun 18, 2025

🐙 Octomind

Test Report: 6/14 successful.

description status details
test all ways to open the setup flow Failed ❌ click
sign-in Failed ❌ click
share_session Failed ❌ click
get started Passed ✅ click
edit_notes_and_actions_v5 Failed ❌ click
create lean coffee board Failed ❌ click
create_and_delete_notes_and_actions_v2 Failed ❌ click
create and delete board columns Failed ❌ click
close cookie banner - sign-in Passed ✅ click
close cookie banner - front page Passed ✅ click
check terms & conditions Passed ✅ click
check Privacy Policy Passed ✅ click
change avatar Failed ❌ click
About Section Visibility Test Passed ✅ click

commit sha: 2a12640

@Schwehn42 Schwehn42 enabled auto-merge June 18, 2025 12:20
@Schwehn42 Schwehn42 added this pull request to the merge queue Jun 18, 2025
Merged via the queue into main with commit 97e8ad2 Jun 18, 2025
16 of 17 checks passed
@Schwehn42 Schwehn42 deleted the js/create-template-view branch June 18, 2025 12:25
@Schwehn42 Schwehn42 moved this from Review to Done in scrumlr.io Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Template Page Goal 2025
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Modal for access settings
5 participants