-
Notifications
You must be signed in to change notification settings - Fork 64
fix: Sort cards after voting #5443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the tests now running reliably?
Tbh i am now sure why they failed. The only difference between the passing branch and failing branch were some package updates. |
The deployment to the dev cluster was successful. You can find the deployment here: https://5443.development.scrumlr.fra.ics.inovex.io Deployed Images
|
Description
Description of the problem can be found here: #5404
Fix inside of
votings/service.go
added logic to sort the notes before sending the results to the frontend
Changelog
Checklist
(Optional) Visual Changes