Skip to content

Conversation

mateo-ivc
Copy link
Collaborator

Description

Description of the problem can be found here: #5404

Fix inside of votings/service.go
added logic to sort the notes before sending the results to the frontend

Changelog

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • The light- and dark-theme are both supported and tested
  • The design was implemented and is responsive for all devices and screen sizes
  • The application was tested in the most commonly used browsers (e.g. Chrome, Firefox, Safari)

(Optional) Visual Changes

Copy link
Collaborator

@Planlos5000 Planlos5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@Planlos5000 Planlos5000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the tests now running reliably?

@mateo-ivc
Copy link
Collaborator Author

Are the tests now running reliably?

Tbh i am now sure why they failed. The only difference between the passing branch and failing branch were some package updates.
And the test only failed because the response was in the wrong order 🤷‍♂️

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://5443.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-86be00f

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-86be00f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants