-
Notifications
You must be signed in to change notification settings - Fork 9
Description
Currently we require that new registrtaions of programmable tokens are allowed only if minting is allowed. However it seems to me that the issuance script does not require tokens to be registered to mint.
I think we should also enforce that the issuance script requires a proof that the token is registered either before or in the same tx as minting. i.e. first mint of a programmable token should be made together with its registration.
I think in the same spirit that we don't want non-programmable assets to be registered and hijacked after being moved to programmableBaseAddresses, the transfer and thirdPartyTransfer logics for a programmable token should be registered prior to any minting of that token. Right now it is possible to mint programmable tokens, distribute them and only later register them in the directory node.
Additionally, given that we don't allow changing of a smart tokens spending logics we should make sure that this is enforced throughout the lifetime of a programmable token, not just after registration.
I think we should be able to do this without cyclic dependency by requiring an extra directoryNodeCS parameter in the issuance script.
(see #92 (comment))