-
-
Notifications
You must be signed in to change notification settings - Fork 39
Fix broken repository URL in package.json #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
GitHub hasn't supported the git protocol [since 2022](https://github.blog/security/application-security/improving-git-protocol-security-github/#no-more-unauthenticated-git), so this URL is broken. (This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)
package.json
Outdated
@@ -62,7 +62,7 @@ | |||
}, | |||
"repository": { | |||
"type": "git", | |||
"url": "git://github.com/inspect-js/object-inspect.git" | |||
"url": "https://github.com/inspect-js/object-inspect.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
git+ssh instead please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed as requested - though as per inspect-js/has-symbols#22 (comment) I think https://
would be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now changed to ssh://
per inspect-js/has-symbols#22 (comment)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
- Coverage 95.97% 94.11% -1.86%
==========================================
Files 2 2
Lines 348 357 +9
Branches 151 155 +4
==========================================
+ Hits 334 336 +2
- Misses 14 21 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
GitHub hasn't supported the git protocol since 2022, so this URL is broken.
(This is a common error affecting many popular npm packages; I'm opening PRs on several projects to fix it. I encourage anyone reading this to check any packages they maintain and implement the same fix if appropriate!)