[OTel] Pika instrumentation #614
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvital
added
the
OTel_migration
pvital
force-pushed
the
otel_instrumentation_pika
branch
2 times, most recently
from
50fa3c1 to
9059ca4
Compare
pvital
force-pushed
the
otel_migration
branch
from
820b226 to
2b4a16f
Compare
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
9059ca4 to
2b37e3b
Compare
CagriYonca
reviewed
Sep 13, 2024
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
2b37e3b to
d4026eb
Compare
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
GSVarsha
reviewed
Sep 17, 2024
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
d4026eb to
55d3cda
Compare
GSVarsha
requested changes
Sep 18, 2024
Contributor
GSVarsha
left a comment
GSVarsha
left a comment
There was a problem hiding this comment.
Can we move all the imports inside the try block so that if pika is not present we can just completely avoid importing everything else?
Member
Author
All of them are inside the try-except block. Could you please re-check it? |
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
55d3cda to
84f195f
Compare
Contributor
I meant these ones. |
Member
Author
Got it. We did not follow this pattern at the beginning of the instrumentation migration, but I guess we can follow it now. I will change it and let you know. |
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
84f195f to
bbf443a
Compare
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
Signed-off-by: Paulo Vital <paulo.vital@ibm.com>
pvital
force-pushed
the
otel_instrumentation_pika
branch
from
bbf443a to
c175b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test coverage: 98%