-
Notifications
You must be signed in to change notification settings - Fork 35
fix: tracing fastapi app #805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7fcec7e to
9e8282a
Compare
|
Got following error on CI test but it looks like not caused by my pr python 3.12 kafka
python 3.13 test
|
9e8282a to
223455f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pvital Added else statement. Could you please take a look for this pr again?
223455f to
971f35a
Compare
Signed-off-by: minatooni <minato.work.i.mm@gmail.com>
65b17e0 to
889adf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me.
close #804
Here, FastAPI accepts
Sequenceand the current implementation ofInstanaASGIMiddlewareinsert does not cover tuplehttps://github.com/fastapi/fastapi/blob/450a334253b1426aab08b4dea17b16ba8b4c098c/fastapi/applications.py#L472
Are there any document that describes how to run tests? This is super small change tho