The function of "Reset Course Content" is unclear at first glance. Changed to more descriptive button name.#2248
Open
naneko wants to merge 1 commit into
Open
The function of "Reset Course Content" is unclear at first glance. Changed to more descriptive button name.#2248naneko wants to merge 1 commit into
naneko wants to merge 1 commit into
Conversation
…elete Course Content" is more descriptive. Functionality still maintains the name "reset" in code.
|
|
DHurtado714
approved these changes
Oct 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am ashamed to admit that I made a mistake in a production Canvas environment and deleted my course by accident. Luckily I think our administrators have a backup. I misconstrued "Reset Course Content" to mean resetting course progression for students. I think its much clearer to just call it "Delete Course Content" since that is what the button is actually doing. Based on my quick Google searches it seems I am not the only person who has made this mistake.
Also I know there's a lightbox dialog that somewhat clarifies the functionality but I still misread it and thought it would just reset course progression.
I don't think this warrants changing the naming convention for the functionality in code (since "reset" can help differentiate from "delete course" functionality) but I am happy to go through and update this as well if its deemed necessary.