Upgrade libwebrtc-bin to 141.0.7390.107 version (#260)

Author: alexlapa

CHANGELOG.md

@@ -26,7 +26,7 @@ All user visible changes to this project will be documented in this file. This p
 
 ### Changed
 
-- Upgraded [libwebrtc] to [141.0.7390.76] version. ([#256], [#254], [#248])
+- Upgraded [libwebrtc] to [141.0.7390.107] version. ([#256], [#254], [#248], [#260])
 - Removed camera permission request in `enumerateDevices()` on Android. ([#258])
 
 ### Fixed
@@ -46,7 +46,8 @@ All user visible changes to this project will be documented in this file. This p
 [#256]: https://github.com/instrumentisto/medea-flutter-webrtc/pull/256
 [#257]: https://github.com/instrumentisto/medea-flutter-webrtc/pull/257
 [#258]: https://github.com/instrumentisto/medea-flutter-webrtc/pull/258
-[141.0.7390.76]: https://github.com/instrumentisto/libwebrtc-bin/releases/tag/141.0.7390.76
+[#260]: https://github.com/instrumentisto/medea-flutter-webrtc/pull/260
+[141.0.7390.107]: https://github.com/instrumentisto/libwebrtc-bin/releases/tag/141.0.7390.107
 
 
 

Cargo.lock

@@ -2,7 +2,7 @@ Medea Flutter-WebRTC
 ====================
 
 [![pub](https://img.shields.io/pub/v/medea_flutter_webrtc "pub")](https://pub.dev/packages/medea_flutter_webrtc)
-[![libwebrtc](https://img.shields.io/badge/libwebrtc-141.0.7390.76-blue "libwebrtc")](https://github.com/instrumentisto/libwebrtc-bin/releases/tag/141.0.7390.76)
+[![libwebrtc](https://img.shields.io/badge/libwebrtc-141.0.7390.107-blue "libwebrtc")](https://github.com/instrumentisto/libwebrtc-bin/releases/tag/141.0.7390.107)
 [![OpenAL](https://img.shields.io/badge/OpenAL-1.24.3-blue "OpenAL")](https://github.com/kcat/openal-soft/releases/tag/1.24.3)
 [![WIL](https://img.shields.io/badge/WIL-1.0.240803.1-blue "WIL")](https://github.com/microsoft/wil/releases/tag/v1.0.240803.1)
 

README.md

@@ -63,7 +63,7 @@ android {
 
     dependencies {
         if (webrtcBranch == null) {
-            implementation "com.github.instrumentisto:libwebrtc-bin:141.0.7390.76@aar"
+            implementation "com.github.instrumentisto:libwebrtc-bin:141.0.7390.107@aar"
         } else {
             implementation(name: "libwebrtc-bin-${webrtcBranch}", ext: 'aar')
         }

android/build.gradle

@@ -1,6 +1,6 @@
 [package]
 name = "libwebrtc-sys"
-version = "0.0.0+141.0.7390.76"
+version = "0.0.0+141.0.7390.107"
 edition = "2024"
 rust-version = "1.90"
 publish = false

crates/libwebrtc-sys/Cargo.toml

@@ -28,7 +28,7 @@ static LIBWEBRTC_URL: &str = "https://github.com/instrumentisto/libwebrtc-bin";
 /// Release tag for downloading the [`libwebrtc-bin`].
 ///
 /// [`libwebrtc-bin`]: https://github.com/instrumentisto/libwebrtc-bin
-static LIBWEBRTC_RELEASE: &str = "141.0.7390.76";
+static LIBWEBRTC_RELEASE: &str = "141.0.7390.107";
 
 /// Base URL for the [`libwebrtc-bin`] GitHub API.
 ///
@@ -40,19 +40,19 @@ static GITHUB_API_URL: &str =
 fn get_expected_libwebrtc_hash() -> anyhow::Result<&'static str> {
     Ok(match get_target()? {
         Platform::LinuxArm64 => {
-            "6c7daad16e667d5ca822a08e03cb05718c187745d8cd6a4b02e2cbb9966440e4"
+            "2bf03cb548f1f59cdf84b8294ab7df3d6b492fdbde26f7f187e73c15e11e8442"
         }
         Platform::LinuxX64 => {
-            "78c78cc4d03846f12832ce09bcd5913d511e6fe4789dae7e303c239336620c5b"
+            "5de787524c3b69bda7f2f5a6c976612ed020a9a7eb1d8548adc071ad8da1aaf3"
         }
         Platform::MacOSArm64 => {
-            "d7baeb1b3de188d93e2ece1b487ae8f5c7d34f1ef391642431da900daa589e26"
+            "ed0db508b0143e1500423fcaef7ff1fb28362eb299fc0e566c8c82b6ffd10b0c"
         }
         Platform::MacOSX64 => {
-            "181e0e19cffe93995f214a0a04829e9b13ad11a2a1c7986f12fc7ed49bc22cc0"
+            "1836fafbdb82f105c920ae7e00ff6624cf2fc70615b6fe1af490f4d6102904d2"
         }
         Platform::WindowsX64 => {
-            "52f2bce8c9e22f90bf9c0b13767a6eae559c87be51148dafbf4eeb264d840d9f"
+            "3cc386b2b19d44c14c83e7d8ddf1c60798ab621b2e962cdd91194c323d43e3ce"
         }
     })
 }

crates/libwebrtc-sys/build/webrtc.rs

@@ -1533,6 +1533,39 @@ void main() {
     await audioTrack.dispose();
   });
 
+  testWidgets('setLocalDescription', (WidgetTester tester) async {
+    // Tests the previously fixed issue in `libwebrtc-bin` caused by
+    // `VideoDecoderFactory` not supporting some codecs that
+    // `VideoEncoderFactory` declared to support. This caused these codecs
+    // to be included in an SDP offer and rejected in the `setLocalDescription`.
+    // Performs 2 negotiations and changes transceiver direction to hit certain
+    // branches in `libwebrtc` source code.
+    var pc1 = await PeerConnection.create(IceTransportType.all, []);
+    var tv = await pc1.addTransceiver(
+      MediaKind.video,
+      RtpTransceiverInit(TransceiverDirection.sendRecv),
+    );
+    var ta = await pc1.addTransceiver(
+      MediaKind.audio,
+      RtpTransceiverInit(TransceiverDirection.sendRecv),
+    );
+
+    {
+      tv.setDirection(TransceiverDirection.sendOnly);
+      var offer = await pc1.createOffer();
+      await pc1.setLocalDescription(offer);
+    }
+    {
+      tv.setDirection(TransceiverDirection.sendRecv);
+      var offer = await pc1.createOffer();
+      await pc1.setLocalDescription(offer);
+    }
+
+    await ta.dispose();
+    await tv.dispose();
+    await pc1.close();
+  });
+
   testWidgets('Audio processing in get user media', (
     WidgetTester tester,
   ) async {

example/integration_test/webrtc_test.dart

@@ -1,11 +1,11 @@
 PODS:
   - Flutter (1.0.0)
-  - instrumentisto-libwebrtc-bin (141.0.7390.76)
+  - instrumentisto-libwebrtc-bin (141.0.7390.107)
   - integration_test (0.0.1):
     - Flutter
   - medea_flutter_webrtc (0.16.0-dev):
     - Flutter
-    - instrumentisto-libwebrtc-bin (= 141.0.7390.76)
+    - instrumentisto-libwebrtc-bin (= 141.0.7390.107)
 
 DEPENDENCIES:
   - Flutter (from `Flutter`)