Skip to content

Take2 #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Nov 1, 2024
Merged

Take2 #683

merged 9 commits into from
Nov 1, 2024

Conversation

charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Oct 29, 2024 •
edited by andersy005
Loading

Change Summary

  • Updated intake version number to >2.0 in
    • requirements.txt
    • ci/environment.yml
    • ci/environment-docs.yml
  • Specify xarray !=2024.10 (appear to be some issues related to datatree).
  • Added explicit dask dependency (implicit dask dependency provided by intake < 2.0 removed in version 2.0)

Related issue number

Checklist

  • Unit tests for the changes exist ( Dependency change - all tests passing).
  • Tests pass on CI (Read the Docs issue again).
  • Documentation reflects the changes where applicable ( I've grepped through the docs and can't find any reference to the intake version).

@charles-turner-1 charles-turner-1 marked this pull request as ready for review October 29, 2024 03:57
andersy005
andersy005 approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@andersy005 andersy005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍🏽

@andersy005 andersy005 added the dependencies Pull requests that update a dependency file label Oct 29, 2024
@charles-turner-1
Copy link
Collaborator Author

Same RTD issue as: #681 (review)

@charles-turner-1 charles-turner-1 merged commit 9ac6120 into intake:main Nov 1, 2024
5 of 6 checks passed
@charles-turner-1 charles-turner-1 mentioned this pull request Nov 15, 2024
Closed
@charles-turner-1 charles-turner-1 deleted the take2 branch September 9, 2025 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbeucher rbeucher rbeucher approved these changes

@andersy005 andersy005 andersy005 approved these changes

@mgrover1 mgrover1 Awaiting requested review from mgrover1 mgrover1 is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intake Take2 is about to release
3 participants
@charles-turner-1 @rbeucher @andersy005