Update to zarr v3 #735
Merged
Update to zarr v3 #735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… behaviour too I think
mgrover1
requested changes
Aug 8, 2025
There was a problem hiding this comment.
Only comment here is to add this in the docs under the catalog spec section, other than that, this looks great! 🎉
https://intake-esm.readthedocs.io/en/stable/reference/esm-catalog-spec.html#
…. I think we can do better & take care of this for the user
…tion in the data format
|
@mgrover1 not quite sure what you meant by that so I might have gone a bit overboard - added distinct Some tests that I added in a recent PR apparently didn't get merged & got dragged in with this PR. I'll see if I can get codecov running again so I don't make any more mistakes like that... |
|
@martindurant does intake have a codecov account? I'd like to get the code coverage CI step running again if possible. |
mgrover1
approved these changes
Aug 11, 2025
Sorry, no. |
Closed
charles-turner-1
added a commit
that referenced
this pull request
Aug 21, 2025
* Tests all passing? Deps must have updated since I last tried * Missing environment bits * Apparently the bugfix was in zarr v3.0.10 * Fix requirements in ci/env*.yml * Allow zarr <3.0 or >=3.0.10 * Change async in test based on zarr version - we can make this default behaviour too I think * Move `_zarr_async` to utils module * Add asynchronous/synchronous note to docs under Assets object section. I think we can do better & take care of this for the user * @mgrover1 comment, add some extra tests, allow zarr version specification in the data format * Misformatted esm-catalog-spec * Re-pin minimum zarr version * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
'asynchronous': Truetotest_open_dataset_kerchunk- fails otherwise. We probably want to add this to the documentation?Related issue number
#727
Checklist