Skip to content

Conversation

charles-turner-1
Copy link
Collaborator

@charles-turner-1 charles-turner-1 commented Sep 1, 2025

Change Summary

  • In Add parquet driver #728, I added support for reading .parquet files, but completely forgot to add support for serialising catalogs back to them. This PR fixes that.
  • Cleans up an issue with available compression associated with that PR.
  • Tests we can deserialise and reserialise (from {.csv,.parquet} => {.csv, .parquet}).
  • Adds write_kwargs, a la read_kwargs in Add parquet driver #728, plus soft deprecation of the to_csv_kwargs keywods argument when serialising.

N.B: Deserialisation & reserialisation tests round trip twice, it looks like the defaults for how empty catalog field options (in catalog.json) have changed since that catalog was created.

Checklist

  • Unit tests for the changes exist
  • Tests pass on CI
  • Documentation reflects the changes where applicable
    • Will need to update ecgtools first to allow for quickstart guide update.
    • Relevant API reference bits updated.

I will no longer make pull requests when jetlagged.

Add note on default's that might have changed?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant