Add ruff and isort #578
Merged
Add ruff and isort #578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sun, Xuehao <xuehao.sun@intel.com>
XuehaoSun
force-pushed
the
xuehao/pre-commit
branch
from
6d45ee0 to
47a8063
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
wenhuach21
approved these changes
Jul 24, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds ruff and isort as code linting and formatting tools to the project. The changes introduce comprehensive code style enforcement through configuration files and pre-commit hooks, while making extensive formatting changes throughout the codebase to conform to the new standards.
- Adds ruff and isort configuration in pyproject.toml with specific linting rules and import sorting settings
- Updates pre-commit configuration to include new linting and formatting hooks
- Applies extensive import reordering and code formatting across the entire codebase to meet new standards
Reviewed Changes
Copilot reviewed 96 out of 97 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Added comprehensive ruff and isort configuration settings |
| .pre-commit-config.yaml | Added pre-commit hooks for ruff and isort, plus additional code quality checks |
| test//test_.py | Reordered imports and applied formatting fixes across all test files |
| auto_round/*.py | Applied import sorting and formatting changes to core library files |
| auto_round_extension/*.py | Added copyright headers and formatting fixes to extension modules |
| setup.py | Minor import reordering and code style improvements |
Comment on lines
+51
to
+79
| assert is_pure_text_model(model) | ||
|
|
||
| def test_Qwen(self): | ||
| model_name = "/models/Qwen2.5-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_phi4(self): | ||
| model_name = "/models/phi-4" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [40]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_llama3(self): | ||
| model_name = "/models/Meta-Llama-3.1-8B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_mixtral(self): | ||
| model_name = "/models/Mixtral-8x7B-Instruct-v0.1" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) |
There was a problem hiding this comment.
Use of bare assert statement without descriptive message. Consider adding a descriptive message for better debugging: assert is_pure_text_model(model), "Expected model to be pure text model"
Copilot uses AI. Check for mistakes.
Comment on lines
+51
to
+93
| assert is_pure_text_model(model) | ||
|
|
||
| def test_Qwen(self): | ||
| model_name = "/models/Qwen2.5-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_phi4(self): | ||
| model_name = "/models/phi-4" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [40]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_llama3(self): | ||
| model_name = "/models/Meta-Llama-3.1-8B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_mixtral(self): | ||
| model_name = "/models/Mixtral-8x7B-Instruct-v0.1" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_falcon(self): | ||
| model_name = "/models/Falcon3-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_orca(self): | ||
| model_name = "/models/Orca-2-7b" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) |
There was a problem hiding this comment.
Use of bare assert statement without descriptive message. Consider adding a descriptive message for better debugging: assert is_pure_text_model(model), "Expected model to be pure text model"
Copilot uses AI. Check for mistakes.
Comment on lines
+51
to
+100
| assert is_pure_text_model(model) | ||
|
|
||
| def test_Qwen(self): | ||
| model_name = "/models/Qwen2.5-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_phi4(self): | ||
| model_name = "/models/phi-4" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [40]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_llama3(self): | ||
| model_name = "/models/Meta-Llama-3.1-8B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_mixtral(self): | ||
| model_name = "/models/Mixtral-8x7B-Instruct-v0.1" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_falcon(self): | ||
| model_name = "/models/Falcon3-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_orca(self): | ||
| model_name = "/models/Orca-2-7b" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_OLMo(self): | ||
| model_name = "/models/OLMo-2-1124-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) |
There was a problem hiding this comment.
Use of bare assert statement without descriptive message. Consider adding a descriptive message for better debugging: assert is_pure_text_model(model), "Expected model to be pure text model"
Copilot uses AI. Check for mistakes.
Comment on lines
+51
to
+100
| assert is_pure_text_model(model) | ||
|
|
||
| def test_Qwen(self): | ||
| model_name = "/models/Qwen2.5-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_phi4(self): | ||
| model_name = "/models/phi-4" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [40]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_llama3(self): | ||
| model_name = "/models/Meta-Llama-3.1-8B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_mixtral(self): | ||
| model_name = "/models/Mixtral-8x7B-Instruct-v0.1" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_falcon(self): | ||
| model_name = "/models/Falcon3-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [28]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_orca(self): | ||
| model_name = "/models/Orca-2-7b" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) | ||
|
|
||
| def test_OLMo(self): | ||
| model_name = "/models/OLMo-2-1124-7B-Instruct" | ||
| model = AutoModelForCausalLM.from_pretrained(model_name, torch_dtype="auto", trust_remote_code=True) | ||
| block_names = get_block_names(model) | ||
| self.check_block_names(block_names, ["model.layers"], [32]) | ||
| assert is_pure_text_model(model) == True | ||
| assert is_pure_text_model(model) |
There was a problem hiding this comment.
Use of bare assert statement without descriptive message. Consider adding a descriptive message for better debugging: assert is_pure_text_model(model), "Expected model to be pure text model"
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ruff and isort