Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Commit e1f5dc1

Browse files
mattnmattn
committed
Do not use std::move for local scoped values
1 parent 60e757e commit e1f5dc1

16 files changed

+31
-31
lines changed

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_MMAD.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ namespace kernel_selector
5454
runInfo->lws1 = 1;
5555
runInfo->lws2 = sub_group_size;
5656

57-
return std::move(runInfo);
57+
return runInfo;
5858
}
5959

6060
JitConstants FullyConnectedKernelMMAD::GetJitConstants(const fully_connected_params& params, const DispatchData& runInfo) const
@@ -86,4 +86,4 @@ namespace kernel_selector
8686
}
8787
return res;
8888
}
89-
}
89+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_base.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ namespace kernel_selector
6464
}
6565
dispatchData->lws1 = dispatchData->lws2 = 1;
6666

67-
return std::move(dispatchData);
67+
return dispatchData;
6868
}
6969

7070
KernelsData FullyConnectedKernelBase::GetCommonKernelsData(const Params& params, const optional_params& options, DataLayout dl, std::vector<WeightsLayout> wl, float estimated_time, const std::string exeMode, int autoTuneIndex) const
@@ -144,4 +144,4 @@ namespace kernel_selector
144144
return GetCommonKernelsData(params, options, dl, wl, estimated_time, GetAutoTuneOptions(autoTuneIndex), autoTuneIndex);
145145
}
146146

147-
}
147+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bf_io_gemm.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ namespace kernel_selector {
5757

5858
runInfo->effiency = FORCE_PRIORITY_6;
5959

60-
return std::move(runInfo);
60+
return runInfo;
6161
}
6262

6363
JitConstants FullyConnected_bf_io_GEMM::GetJitConstants(const fully_connected_params& params, const DispatchData& kd) const

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bf_io_input_spatial.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace kernel_selector
5959
}
6060
}
6161

62-
return std::move(kd);
62+
return kd;
6363
}
6464

6565
bool FullyConnected_bf_io_input_spatial::Validate(const Params& p, const optional_params& o) const
@@ -122,4 +122,4 @@ namespace kernel_selector
122122

123123
return res;
124124
}
125-
}
125+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bfyx_ref.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ namespace kernel_selector
6161
runInfo->lws1 = local[1];
6262
runInfo->lws2 = 1;
6363

64-
return std::move(runInfo);
64+
return runInfo;
6565
}
6666

6767
KernelsData FullyConnected_bfyx_Ref::GetKernelsData(const Params& params, const optional_params& options) const
@@ -80,4 +80,4 @@ namespace kernel_selector
8080

8181
return res;
8282
}
83-
}
83+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bs_f_bsv16_af8.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ namespace kernel_selector
4545
kd->lws0 = 16;
4646
kd->lws1 = 1;
4747

48-
return std::move(kd);
48+
return kd;
4949
}
5050

5151
static bool check_input_layout(const DataTensor& t)
@@ -97,4 +97,4 @@ namespace kernel_selector
9797

9898
return res;
9999
}
100-
}
100+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bs_f_bsv16_b1.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ namespace kernel_selector
9292
kd->in_chunk_prefetch_size = 2;
9393
kd->filter_chunk_prefetch_size = responses_per_sg_exec;
9494

95-
return std::move(run_info);
95+
return run_info;
9696
}
9797

9898
KernelsData FullyConnected_bs_f_bsv16_b1::GetKernelsData(const Params& params, const optional_params& optParams) const
@@ -109,4 +109,4 @@ namespace kernel_selector
109109

110110
return res;
111111
}
112-
}
112+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_bs_f_bsv8_af8.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ namespace kernel_selector
4747
kd->lws0 = 8;
4848
kd->lws1 = 1;
4949

50-
return std::move(kd);
50+
return kd;
5151
}
5252

5353
static bool check_input_layout(const DataTensor& t)
@@ -113,4 +113,4 @@ namespace kernel_selector
113113

114114
return res;
115115
}
116-
}
116+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_fb_io_b8_f8.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ namespace kernel_selector
4848
kd->lws0 = 8;
4949
kd->lws1 = 1;
5050

51-
return std::move(kd);
51+
return kd;
5252
}
5353

5454
bool FullyConnected_fb_io_b8_f8::Validate(const Params& p, const optional_params& o) const
@@ -97,4 +97,4 @@ namespace kernel_selector
9797

9898
return res;
9999
}
100-
}
100+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_fb_io_block.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ namespace kernel_selector
7070
kd->units_per_sg_read = units_per_sg_read;
7171
kd->rg_count = (uint32_t)rg_count;
7272
kd->last_rg_size = response_size % units_per_sg_read;
73-
return std::move(kd);
73+
return kd;
7474
}
7575

7676
JitConstants FullyConnected_fb_io_block::GetJitConstants(const fully_connected_params& params, const FullyConnectedKernelBase::DispatchData& run_info) const
@@ -159,4 +159,4 @@ namespace kernel_selector
159159

160160
return res;
161161
}
162-
}
162+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_fb_oi_b8_ref.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ namespace kernel_selector
4444
kd->lws0 = 8;
4545
kd->lws1 = 1;
4646

47-
return std::move(kd);
47+
return kd;
4848
}
4949

5050
bool FullyConnected_fb_oi_b8_ref::Validate(const Params& p, const optional_params& o) const
@@ -77,4 +77,4 @@ namespace kernel_selector
7777
}
7878
return res;
7979
}
80-
}
80+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_fs_byx_fsv32.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace kernel_selector {
5656

5757
runInfo->effiency = FORCE_PRIORITY_5;
5858

59-
return std::move(runInfo);
59+
return runInfo;
6060
}
6161

6262
JitConstants FullyConnected_fs_byx_fsv32::GetJitConstants(const fully_connected_params& params, const DispatchData& kd) const

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_imad.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ namespace kernel_selector
5959
runInfo->lws1 = 1;
6060
runInfo->lws2 = 1;
6161

62-
return std::move(runInfo);
62+
return runInfo;
6363
} // SetDefault
6464

6565
bool FullyConnectedKernelIMAD::Validate(const Params& params, const optional_params& options) const
@@ -113,4 +113,4 @@ namespace kernel_selector
113113
}
114114
return res;
115115
}
116-
}
116+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_image_tutorial.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ namespace kernel_selector
5757

5858
runInfo->effiency = TUTORIAL_PRIORITY;
5959

60-
return std::move(runInfo);
60+
return runInfo;
6161
}
6262

6363
KernelsData FullyConnected_image_tutorial::GetKernelsData(const Params& params, const optional_params& options) const
@@ -74,4 +74,4 @@ namespace kernel_selector
7474
}
7575
return res;
7676
}
77-
}
77+
}

‎kernel_selector/core/actual_kernels/fully_connected/fully_connected_kernel_mmad_batched.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ namespace kernel_selector
105105
runInfo->lws2 = 1;
106106

107107
runInfo->effiency = FORCE_PRIORITY_1;
108-
return std::move(runInfo);
108+
return runInfo;
109109
}
110110

111111
KernelsData FullyConnected_mmad_batched::GetKernelsData(const Params& params, const optional_params& options) const
@@ -122,4 +122,4 @@ namespace kernel_selector
122122
}
123123
return res;
124124
}
125-
}
125+
}

‎src/gpu/kernels_cache.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ namespace {
7979
undefs += "#endif\n";
8080
}
8181

82-
return std::move(undefs);
82+
return undefs;
8383
}
8484

8585
std::string reorder_options(const std::string& org_options)
@@ -181,7 +181,7 @@ kernels_cache::sorted_code kernels_cache::get_program_source(const kernels_code&
181181
current_bucket.kernels_counter++;
182182
}
183183

184-
return std::move(scode);
184+
return scode;
185185
}
186186

187187
kernels_cache::kernels_cache(gpu_toolkit& context): _context(context) {}
@@ -354,4 +354,4 @@ void kernels_cache::build_all()
354354
}
355355

356356
}}
357-
357+

0 commit comments

Comments
 (0)