Skip to content

Run CI for stacked/** branches #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Run CI for stacked/** branches #4557

wants to merge 1 commit into from

Conversation

kwasd
Copy link
Contributor

@kwasd kwasd commented Jun 23, 2025

Perhaps for the push event it is excessive, let's see how it goes, then tune as necessary.

@kwasd kwasd requested review from whitneywhtsang and etiotto June 23, 2025 12:56
@kwasd kwasd enabled auto-merge (squash) June 23, 2025 13:04
@kwasd kwasd disabled auto-merge June 23, 2025 13:16
@kwasd
Copy link
Contributor Author

kwasd commented Jun 23, 2025 •
edited
Loading

Isn't it better to run CI for all PRs, not limited to main, release/** and stacked/**?
Seems like majority of open PRs are against the main anyway.
I don't think there is any changes in security, since everyone can open an PR against main now

@whitneywhtsang whitneywhtsang requested a review from pbchekin June 23, 2025 16:32
whitneywhtsang
whitneywhtsang reviewed Jun 23, 2025
View reviewed changes
Copy link
Contributor

@whitneywhtsang whitneywhtsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to defer the decision until Pavel returns.

@whitneywhtsang whitneywhtsang marked this pull request as draft June 23, 2025 16:54
@kwasd
Copy link
Contributor Author

kwasd commented Jun 23, 2025

@whitneywhtsang Why to defer? I think, with @vlad-penkin we can reach a consensus.

@kwasd kwasd requested a review from vlad-penkin June 23, 2025 18:30
@whitneywhtsang
Copy link
Contributor

@whitneywhtsang Why to defer? I think, with @vlad-penkin we can reach a consensus.

I thought we wanted to defer from the discussion in the architecture meeting.
My preference is to either keep as is (only main and release branch), or run for all PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whitneywhtsang whitneywhtsang whitneywhtsang left review comments

@etiotto etiotto etiotto approved these changes

@pbchekin pbchekin Awaiting requested review from pbchekin

@vlad-penkin vlad-penkin Awaiting requested review from vlad-penkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kwasd @whitneywhtsang @etiotto