Conversation
Contributor
|
@desmonddak relative to #259 is this just a subset? Trying to figure out what I've already reviewed and what I still need to review. |
Contributor
Author
|
This is a strict subset of #259, everything but the cache stuff. There are some directory moves to organize for the number of files being added. The CAM is added as well as things like the RV-Fifo. |
kimmeljo
reviewed
Feb 5, 2026
Contributor
kimmeljo
left a comment
kimmeljo
left a comment
There was a problem hiding this comment.
Hoping to get a few quick clarifications especially after having delved into Cam more closely.
| required List<Logic> fields, | ||
| }) : super(fields, name: config.name); | ||
|
|
||
| String? logicName, |
Contributor
There was a problem hiding this comment.
Can you give an example of why this is needed? I'm not sure I understand from the comment alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
This is a subset of the cache2 PR that includes adding ready-valid interfaces, the ready-valid FIFO, a CAM, and some reorganization to prepare for cache componentry.
Related Issue(s)
None.
Testing
Ran full suite of tests including new test for new components.
Backwards-compatibility
No.
Documentation
Yes. Markdown is included for new components.