-
Notifications
You must be signed in to change notification settings - Fork 12
Addition of radio-astronomy use-case #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two folders currently - "radio-astronomy-raw", which is a direct copy of "https://gitlab.com/ml-ppa/pulsarrfi_nn" "version_0.2" branch, and radio-astronomy, in which this old code will eventually be integrated into itwinai framework.
Add optional dependencies for radio-astronomy package in .toml and remove tensorflow CNN
Added additional dependencies for running radio-astronomy code, translated one .ipynb file into .py file for easier development on HPC systems.
Added new files for radio-astronomy use-case. Existing pulsar code should be generalized for effective itwinai integration.
…unctionality on 1 network
Finalized integration tests for 5 pipelines, updated docs for the tests.
Merge remote-tracking branch 'origin/main' into radio-astronomy
okrochak
commented
May 5, 2025
matbun
reviewed
May 7, 2025
1. Small changes to return type in data.py 2. Fixed docstring style in test_radio_astronomy.py 3. A very small change to return type in trainer.py
matbun
approved these changes
May 7, 2025
matbun
requested changes
May 8, 2025
matbun
approved these changes
May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Includes documentation, test suite composed of 5 tests, and interface implementation to
ensure smooth integration of the radio-astronomy source code into itwinai framework.
The training pipeline is quite sophisticated, as the model is composed of 3 subnetworks.
However, execution is simplified via config.yaml file.
For more information, please view the related documentation for this use-case
Commit history can be quite messy as I was not familiar with itwinai at the beginning.
**Related issue : https://github.com/interTwin-eu/itwinai/issues/162 **