Skip to content

Adding HDX as a collateral on Interlay #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding HDX as a collateral on Interlay #13

wants to merge 3 commits into from

Conversation

@StreetYo
Copy link

@StreetYo StreetYo commented Feb 20, 2024 •
edited
Loading

Hey, guys. I'd like to add HDX as a collateral on Interlay. I have added HDX to the config file and run the calculation the logs of which are in the log file. Is this enough or do I need to do something else?

@philippb90
Copy link
Contributor

The field depeg_adjustment in the config optional and used to account for depegs of stable coins and LSTs. So in the case of HDX this is not really applicable. You can leave as if (it might result in sightly higher ratios) or remove it (or set to 0) in order to maybe get a bit lower thresholds. Otherwise everything looks good.

philippb90
philippb90 suggested changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@philippb90 philippb90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you changed the config but didn't re-run the analysis, so your change is not yet reflected in the results. Ideally you'd re-run and submit it again with the updated thresholds.

@StreetYo
Copy link
Author

Hi @philippb90.
I have re-run it. Does it look good?

@StreetYo StreetYo requested a review from philippb90 February 27, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@philippb90 philippb90 Awaiting requested review from philippb90

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StreetYo @philippb90