-
Notifications
You must be signed in to change notification settings - Fork 73
add edition and thesis fields #752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjust to appropriate version and good to merge!
@@ -1,7 +1,5 @@ | |||
# Optional metadata fields list | |||
|
|||
_Introduced in InvenioRDM v12_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the v12 tag since it's not fully accurate (some of the fields will only be in v13)
So do you want to mark this as Introduced in v13 or granularly indicate which were added in v12 and which in v13?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the v13 additions next to the new fields. I don't feel like we need to be super explicit about that these fields weren't around in non-supported versions like v11....but could if you think we should.
This is now up-to-date with the new structure and the rc1 of v13. I simplified the screenshots so we have fewer to recreate in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(let's see if I can accept the modifications and merge) Nope, I can't. I'll let you accept the patches and then we can merge no problem.
|
||
Anything to mention? | ||
These is a new field called copyright for copyright information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These is a new field called copyright for copyright information | |
There is a new field called copyright for copyright information |
Anything to mention? | ||
These is a new field called copyright for copyright information | ||
|
||
These are new thesis metadata fields including department, type, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are new thesis metadata fields including department, type, | |
There are new thesis metadata fields including department, type, |
❤️ Thank you for your contribution!
Description
Document fields added in inveniosoftware/invenio-rdm-records#1696
I removed the v12 tag since it's not fully accurate (some of the fields will only be in v13)
Checklist
Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:
master
branch.production
branch following approval or indicate to a maintainer that it should be backported.Reminder
By using GitHub, you have already agreed to the GitHub’s Terms of Service including that: