jobs: remove string cast for since argument
#817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The `since` parameter was string-cast to fix a previous bug in Oct 2024, e.g. in `invenio-vocabularies`: inveniosoftware/invenio-vocabularies#419 * In inveniosoftware/invenio-jobs#87, this string cast is now being removed. The documentation has been updated to no longer recommend adding this string cast.
kpsherva
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please release this PR at the same time as the other changes mentioned in inveniosoftware/invenio-jobs#87 (comment)
Closes inveniosoftware/invenio-jobs#87
The
sinceparameter was string-cast to fix a previous bug in Oct 2024 across multiple Invenio modules, e.g. ininvenio-vocabularies:jobs: pass since as string to task invenio-vocabularies#419
In Incorrect
since: datetimeargument handling invenio-jobs#87, this string cast is now being removed. The documentation has been updated to no longer recommend adding this string cast.